Understood. Thank you for explanation.
- Alexey
On 8/28/2019 12:43 PM, Andy Herrick wrote:
On 8/28/2019 11:47 AM, Alexey Semenyuk wrote:
Looks good.
Some files in the review contain no diffs though, like
On 8/28/2019 11:47 AM, Alexey Semenyuk wrote:
Looks good.
Some files in the review contain no diffs though, like
http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html.
Why are they in the review?
I ran a script to
Looks good.
Some files in the review contain no diffs though, like
http://cr.openjdk.java.net/~herrick/8229979/webrev.01/test/jdk/tools/jpackage/windows/exe/WinUpgradeUUIDTest.java.sdiff.html.
Why are they in the review?
- Alexey
On 8/28/2019 9:36 AM, Andy Herrick wrote:
Please review the
Looks good.
-- Kevin
On 8/28/2019 6:36 AM, Andy Herrick wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229979
[2]
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
[1] https://bugs.openjdk.java.net/browse/JDK-8229979
[2] http://cr.openjdk.java.net/~herrick/8229979/
Thanks,
Andy
