This looks good.
/Andy
On 9/13/2019 8:20 PM, Alexander Matveev wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.01/
- Simplified setting default value for destination folder.
- Undo renaming of output variables to dest.
- Modified help messages as per Andy suggestion.
- Removed
Looks good.
- Alexey
On 9/13/2019 8:20 PM, Alexander Matveev wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.01/
- Simplified setting default value for destination folder.
- Undo renaming of output variables to dest.
- Modified help messages as per Andy suggestion.
- Removed
http://cr.openjdk.java.net/~almatvee/8230521/webrev.01/
- Simplified setting default value for destination folder.
- Undo renaming of output variables to dest.
- Modified help messages as per Andy suggestion.
- Removed obsolete tests as per Alexey suggestion.
Thanks,
Alexander
On 9/12/2019
On 9/12/2019 9:34 PM, Alexander Matveev wrote:
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Renamed "--output" to "--dest" and made it optional with default to
".".
[1]
On 9/12/2019 10:47 PM, Alexey Semenyuk wrote:
http://cr.openjdk.java.net/~almatvee/8230521/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.sdiff.html:
---
126 Path destPath = Paths.get(".").toAbsolutePath();
127 if
http://cr.openjdk.java.net/~almatvee/8230521/webrev.00/src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java.sdiff.html:
---
126 Path destPath = Paths.get(".").toAbsolutePath();
127 if (destPath.getFileName().toString().equals(".")) {
128 dest =
Please review the jpackage fix for bug [1] at [2].
This is a fix for the JDK-8200758-branch branch of the open sandbox
repository (jpackage).
- Renamed "--output" to "--dest" and made it optional with default to ".".
[1] https://bugs.openjdk.java.net/browse/JDK-8230521
[2]
