Re: RFR: JDK-8230653: jpackage error on macOS system without xcode

2019-09-12 Thread Andy Herrick
looks good. /Andy On 9/11/2019 11:46 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Error mentioned in bug report was due to missing Xcode when running SetFile.

Re: RFR: JDK-8230653: jpackage error on macOS system without xcode

2019-09-12 Thread Alexey Semenyuk
Looks good. - Alexey On 9/11/2019 11:46 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Error mentioned in bug report was due to missing Xcode when running SetFile.

RFR: JDK-8230653: jpackage error on macOS system without xcode

2019-09-11 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Error mentioned in bug report was due to missing Xcode when running SetFile. Fixed by not running SetFile if Xcode is not available. This tool used