Re: RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

2019-10-03 Thread Andy Herrick
change looks good. /Andy On 10/2/2019 9:54 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Changed "Java" dir to "app" dir in jpackage app image on macOS. [1]

Re: RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

2019-10-03 Thread Andy Herrick
"investigate" is appropriate verb for a task, but not a bug or enhancement. When proposing a fix please (along with changing the synopsis) change the Issue from a task to a bug or an enhancement. /Andy On 10/2/2019 10:52 PM, Phil Race wrote: Please remove “investigate” from the synopsis.

Re: RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

2019-10-02 Thread Phil Race
Please remove “investigate” from the synopsis. Everywhere. -Phil. > On Oct 2, 2019, at 7:48 PM, Alexey Semenyuk > wrote: > > Looks good. > > - Alexey > >> On 10/2/2019 9:54 PM, Alexander Matveev wrote: >> Please review the jpackage fix for bug [1] at [2]. >> >> This is a fix for the

Re: RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

2019-10-02 Thread Alexey Semenyuk
Looks good. - Alexey On 10/2/2019 9:54 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Changed "Java" dir to "app" dir in jpackage app image on macOS. [1]

RFR: JDK-8231706: Investigate if we can change "Java" dir to "app" dir in jpackage app image

2019-10-02 Thread Alexander Matveev
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Changed "Java" dir to "app" dir in jpackage app image on macOS. [1] https://bugs.openjdk.java.net/browse/JDK-8231706 [2]