Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 10/8/2019 3:29 PM, Alexey Semenyuk wrote: Looks good. - Alexey On 10/8/2019 6:09 PM, Andy Herrick wrote: Minor revision after some discussion: [3]:  http://cr.openjdk.java.net/~herrick/8231910/webrev.02 /Andy On 10/8/2019 3:06 PM, Andy Herrick wr

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Alexey Semenyuk
Looks good. - Alexey On 10/8/2019 6:09 PM, Andy Herrick wrote: Minor revision after some discussion: [3]:  http://cr.openjdk.java.net/~herrick/8231910/webrev.02 /Andy On 10/8/2019 3:06 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Andy Herrick
Minor revision after some discussion: [3]:  http://cr.openjdk.java.net/~herrick/8231910/webrev.02 /Andy On 10/8/2019 3:06 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Th

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Andy Herrick
On 10/8/2019 4:27 PM, Alexey Semenyuk wrote: Anyway - the code to get the wix tools version only once is not really a part of this fix, just triggered by your desire to print out all of the usage text from candle and light when getting their version with --verbose option. So I can remove

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Alexey Semenyuk
On 10/8/2019 4:21 PM, Andy Herrick wrote: On 10/8/2019 3:33 PM, Alexey Semenyuk wrote: Andy, AbstractAppImageBuilder.java: is extra ` + File.separator` by intention? this was just trying to be consistent - doesn't matter to native code who is only one to see this value - but I should proba

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Andy Herrick
On 10/8/2019 3:33 PM, Alexey Semenyuk wrote: Andy, AbstractAppImageBuilder.java: is extra ` + File.separator` by intention? this was just trying to be consistent - doesn't matter to native code who is only one to see this value - but I should probably change back. WinMsiBundler.java: static

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Andy Herrick
yes - $ROOTDIR now means what $APPDIR used to, and this method gets $ROOTDIR/app/ , so getCfgAppDir() is still the right name. /Andy On 10/8/2019 3:23 PM, Philip Race wrote: protected String getCfgAppDir() { - return Path.of("$APPDIR").resolve( - ApplicationLayout.linuxAppImage().appDire

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Alexey Semenyuk
Andy, AbstractAppImageBuilder.java: is extra ` + File.separator` by intention? WinMsiBundler.java: static cache will be a potential problem if jpackage will be used as tool provider, i.e. in scenario when jpackage will be called multiple times per jvm session. - Alexey On 10/8/2019 3:06 PM,

Re: RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Philip Race
protected String getCfgAppDir() { -return Path.of("$APPDIR").resolve( -ApplicationLayout.linuxAppImage().appDirectory()).toString() + File.separator; +return Path.of("$ROOTDIR").resolve( +ApplicationLayout.linuxAppImage().appDirectory()).toStri

RFR: JDK-8231910: Expose the APPDIR variable to applications that use jpackage

2019-10-08 Thread Andy Herrick
Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). This change is to Expose the macro $APPDIR for use in --java-options value, to rename macros to mean what they are called, and to eliminate several un