Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

On 11/18/19 6:26 AM, Jim Laskey wrote: http://cr.openjdk.java.net/~jlaskey/8233116/webrev.04/index.html OK, thanks. The changes in: src/java.base/share/classes/java/lang/String.java test/jdk/java/lang/String/TranslateEscapes.java look fine. -Brent

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Editing glitch.Was there but then it was gone. Thanks Brent. http://cr.openjdk.java.net/~jlaskey/8233116/webrev.04/index.html > On Nov 15, 2019, at 7:47 PM, Brent Christian > wrote: > > Hi, Jim > > > src/java.base/share/classes/java/lang/String.java > > These changes look fine. > > --

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Hi, Jim src/java.base/share/classes/java/lang/String.java These changes look fine. -- test/jdk/java/lang/String/TranslateEscapes.java I'm missing where the new verifyLineTerminator() method gets called. Perhaps that's meant to go here: 83 static void test4() { 84 85 } ?

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

updated webrev: http://cr.openjdk.java.net/~jlaskey/8233116/webrev.03/index.html

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Hi Jim, the tokenizer changes looks good. I was very confused by the dance between: // Indicate that the final string should have escapes translated. shouldTranslateEscapes = true; This: // Conditionally translate or validate escape sequence and add result to string

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Updated webrev: http://cr.openjdk.java.net/~jlaskey/8233116/webrev.01/index.html > On Nov 7, 2019, at 5:23 PM, Brent Christian > wrote: > > Should the new escapes be added to the table in the String.translateEscapes() >

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Yep. :-) Too much juggling. Thank you. > On Nov 7, 2019, at 5:23 PM, Brent Christian > wrote: > > Should the new escapes be added to the table in the String.translateEscapes() > JavaDoc? > > -Brent > > On 11/7/19 6:22 AM, Jim Laskey wrote: >> Please review the following code changes.

Re: RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Should the new escapes be added to the table in the String.translateEscapes() JavaDoc? -Brent On 11/7/19 6:22 AM, Jim Laskey wrote: Please review the following code changes. Provides for the introduction of two new escape sequences \ and \s. \ allows developers to express unwieldy string

RFR: JDK-8233117 Escape Sequences For Line Continuation and White Space (Preview)

Please review the following code changes. Provides for the introduction of two new escape sequences \ and \s. \ allows developers to express unwieldy string literals in a text block as a cluster of short single line segments. The second is to allow developers to express ASCII space, much like