http://cr.openjdk.java.net/~almatvee/8235738/webrev.01/
Fixed testForPresenceOnly spelling error.
Thanks,
Alexander
On 12/13/2019 9:39 AM, Phil Race wrote:
testForPresenseOnly It should be spelt testForPresenceOnly -phil.
On 12/13/19 6:16 AM, Andy Herrick wrote:
I approve these changes.
Looks ugly, but seems to be the only possible fix at the moment. Approved.
- Alexey
On 12/13/2019 1:01 AM, Alexander Matveev wrote:
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading output from "hdiutil attach" was
not exiting immediately after process
testForPresenseOnly It should be spelt testForPresenceOnly -phil.
On 12/13/19 6:16 AM, Andy Herrick wrote:
I approve these changes.
My first thought was that, if reading output only after Process is
complete is valid and safe, then why not do it that way all the time
? But comment in
Hi Andy,
On 13/12/2019 15:16, Andy Herrick wrote:
My second thought is that this indicates an underlying unidentified bug
in the mac native code used by Process or ProcessBuilder , and although
it would be better to identify and resolve the underlying problem, the
fix is needed now, so this
I approve these changes.
My first thought was that, if reading output only after Process is
complete is valid and safe, then why not do it that way all the time ?
But comment in Process javadoc: "Because some native platforms only
provide limited buffer size for standard input and output
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading output from "hdiutil attach" was
not exiting immediately after process terminated with delays upto 20
seconds always and in some case upto 10 minutes and thus test was
timeout. Only possible workaround found is
