Re: RFR: JDK-8236138: Add tests for jmod applications

2019-12-19 Thread Alexey Semenyuk
Mach5 test job was submitted, passed and I verified that changes in tests worked as expected. - Alexey On 12/18/2019 7:17 PM, Philip Race wrote: Code looks fine, I did not run the tests, but +1 assuming this has been run through a mach5 test job already. If not please submit one first. -phil

Re: RFR: JDK-8236138: Add tests for jmod applications

2019-12-18 Thread Philip Race
Code looks fine, I did not run the tests, but +1 assuming this has been run through a mach5 test job already. If not please submit one first. -phil. On 12/18/19, 6:38 AM, Andy Herrick wrote: Code looks good - ran tests locally and all passed. /Andyu On 12/17/2019 8:31 PM, Alexey Semenyuk wrot

Re: RFR: JDK-8236138: Add tests for jmod applications

2019-12-18 Thread Andy Herrick
Code looks good - ran tests locally and all passed. /Andyu On 12/17/2019 8:31 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix updates jtreg tests by adding test coverage for scenarios when jpackage is used for packaging applications bundled in .jmod files. - A

RFR: JDK-8236138: Add tests for jmod applications

2019-12-17 Thread Alexey Semenyuk
Please review fix [2] for jpackage bug [1]. The fix updates jtreg tests by adding test coverage for scenarios when jpackage is used for packaging applications bundled in .jmod files. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236138 [2] http://cr.openjdk.java.net/~asemenyuk/82361