Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-20 Thread Erik Joelsson
f them (in Bundle.java) are modeled after similar patterns in the same function. http://cr.openjdk.java.net/~ihse/JDK-8241310-fix-warnings-in-buildtools/webrev.02 /Magnus regards, Rémi - Mail original - De: "Magnus Ihse Bursie" À: "build-dev" , "core-l

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-20 Thread Magnus Ihse Bursie
On 2020-03-19 18:54, Erik Joelsson wrote: Looks good to me. Thanks. I love the WrapperGenerator using Vector and Hashtable! Yeah. State of the art. I'm still trying to wrap my head around this piece of beauty:     assert !(currentContainer instanceof Entry);    

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-20 Thread Magnus Ihse Bursie
http://cr.openjdk.java.net/~ihse/JDK-8241310-fix-warnings-in-buildtools/webrev.02 /Magnus regards, Rémi - Mail original - De: "Magnus Ihse Bursie" À: "build-dev" , "core-libs-dev" Envoyé: Jeudi 19 Mars 2020 17:53:09 Objet: RFR: JDK-8241310 Fix warning

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-19 Thread Remi Forax
dev" , "core-libs-dev" > > Envoyé: Jeudi 19 Mars 2020 17:53:09 > Objet: RFR: JDK-8241310 Fix warnings in jdk buildtools > The buildtools (java tools needed to be run during the build) have long > been plagued by warnings, includuing deprecations and unchecked > war

Re: RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-19 Thread Erik Joelsson
Looks good to me. I love the WrapperGenerator using Vector and Hashtable! /Erik On 2020-03-19 09:53, Magnus Ihse Bursie wrote: The buildtools (java tools needed to be run during the build) have long been plagued by warnings, includuing deprecations and unchecked warnings, which cannot be

RFR: JDK-8241310 Fix warnings in jdk buildtools

2020-03-19 Thread Magnus Ihse Bursie
The buildtools (java tools needed to be run during the build) have long been plagued by warnings, includuing deprecations and unchecked warnings, which cannot be silenced during the build. This patch fixes all buildtool warnings. Most of the warnings are fixed properly, but a few have had