Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-05-04 Thread Alexey Semenyuk
Looks good. - Alexey On 4/29/2020 10:31 AM, Andy Herrick wrote: Please review fix at [1] for issue [2] The change just adds error when specified icon is not found, and a test for that. /Andy [1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/ [2] - https://bugs.openjdk.java.net/b

Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-04-30 Thread Alexander Matveev
Hi Andy, Looks good. Thanks, Alexander On 4/30/20 4:18 PM, Andy Herrick wrote: revised webrev at [3] - copyrights were updated by previous issue. /Andy [3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/ On 4/29/2020 4:56 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.

Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-04-30 Thread Andy Herrick
revised webrev at [3] - copyrights were updated by previous issue. /Andy [3] http://cr.openjdk.java.net/~herrick/8244018/webrev.02/ On 4/29/2020 4:56 PM, Alexander Matveev wrote: Hi Andy, http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubat

Re: RFR: JDK-8244018: No error message for non-existent icon path

2020-04-29 Thread Alexander Matveev
Hi Andy, http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jpackage/internal/resources/MainResources_ja.properties.frames.html http://cr.openjdk.java.net/~herrick/8244018/webrev.01/src/jdk.incubator.jpackage/share/classes/jdk/incubator/jp

RFR: JDK-8244018: No error message for non-existent icon path

2020-04-29 Thread Andy Herrick
Please review fix at [1] for issue [2] The change just adds error when specified icon is not found, and a test for that. /Andy [1] - http://cr.openjdk.java.net/~herrick/8244018/webrev.01/ [2] - https://bugs.openjdk.java.net/browse/JDK-8244018