Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-17 Thread Alexey Semenyuk
Looks good. - Alexey On 8/14/2020 10:05 AM, Andy Herrick wrote: Please review revised webrev [3] that does not check for client jvm are (always use server) /Andy [3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02 On 8/13/2020 6:03 PM, Philip Race wrote: Do I understand correctly th

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-14 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/14/20 7:05 AM, Andy Herrick wrote: Please review revised webrev [3] that does not check for client jvm are (always use server) /Andy [3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02 On 8/13/2020 6:03 PM, Philip Race wrote: Do I underst

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-14 Thread Philip Race
+1 -phil On 8/14/20, 7:05 AM, Andy Herrick wrote: Please review revised webrev [3] that does not check for client jvm are (always use server) /Andy [3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02 On 8/13/2020 6:03 PM, Philip Race wrote: Do I understand correctly that you are che

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-14 Thread Andy Herrick
Please review revised webrev [3] that does not check for client jvm are (always use server) /Andy [3] - http://cr.openjdk.java.net/~herrick/8250611/webrev.02 On 8/13/2020 6:03 PM, Philip Race wrote: Do I understand correctly that you are checking if the client VM is being specified ? I didn'

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread Phil Race
Only back to 11 and client support ended before that. -Phil. > On Aug 13, 2020, at 7:58 PM, Alexey Semenyuk > wrote: > > Phil, > > jpackage can be used to bundle apps with older JREs. Do you think it doesn't > make sense for this check given this? > > - Alexey > >> On 8/13/2020 6:03 PM, P

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread Alexey Semenyuk
Phil, jpackage can be used to bundle apps with older JREs. Do you think it doesn't make sense for this check given this? - Alexey On 8/13/2020 6:03 PM, Philip Race wrote: Do I understand correctly that you are checking if the client VM is being specified ? I didn't think we had client VMs a

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread alexander . matveev
Hi Andy, Looks good. Thanks, Alexander On 8/13/20 12:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll).

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread Philip Race
Do I understand correctly that you are checking if the client VM is being specified ? I didn't think we had client VMs any more .. -phil. On 8/13/20, 12:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked appla

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread Alexey Semenyuk
Looks good. - Alexey On 8/13/2020 3:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll). /Andy [1] - htt

RFR: JDK-8250611: Cannot display splash screen on Windows

2020-08-13 Thread Andy Herrick
Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll). /Andy [1] - https://bugs.openjdk.java.net/browse/JDK-8250611 [2] - http://cr.ope