On Thu, 25 Feb 2021 17:46:42 GMT, Christoph Langer wrote:
>> I think that did not work because it does not fit the param types of
>> reportAndExit but I can simplify it otherwise.
>
> Ah, I see.
> Maybe it's a bit bike-sheddy but as you're using reportAndExit only twice
> now, wouldn't it be
On Thu, 25 Feb 2021 16:39:25 GMT, Matthias Baesken wrote:
>> src/java.base/share/native/libjli/args.c line 378:
>>
>>> 376: if (st.st_size > MAX_ARGF_SIZE) {
>>> 377: JLI_ReportMessage(CFG_ERROR10, MAX_ARGF_SIZE);
>>> 378: reportAndExit(NULL, NULL);
>>
>> This
On Thu, 25 Feb 2021 16:07:36 GMT, Christoph Langer wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove fclose before exit
>
> src/java.base/share/native/libjli/args.c line 378:
>
>> 376: if
On Thu, 25 Feb 2021 15:40:00 GMT, Matthias Baesken wrote:
>> Sonar reports a finding in args.c, where a file check is done .
>> Stat performs a check on file, and later fopen is called on the file .
>>
>> The coding could be slightly rewritten so that the potential issue is
>> removed (however
> Sonar reports a finding in args.c, where a file check is done .
> Stat performs a check on file, and later fopen is called on the file .
>
> The coding could be slightly rewritten so that the potential issue is removed
> (however I do not think that it is such a big issue).
Matthias Baesken
