Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Mandy Chung
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Lance Andersen
On Thu, 23 Sep 2021 14:53:42 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v3]

2021-09-23 Thread Christian Stein
> This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Add JBS issue `8262944` to the `@bug` list

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v2]

2021-09-23 Thread Alan Bateman
On Thu, 23 Sep 2021 13:40:30 GMT, Christian Stein wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > Christian Stein has updated the pull request incrementally with one > additional commit since

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file [v2]

2021-09-23 Thread Christian Stein
> This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Christian Stein has updated the pull request incrementally with one additional commit since the last revision: Assert that only the name of the JAR file

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Christian Stein
On Thu, 23 Sep 2021 11:26:26 GMT, Alan Bateman wrote: >> This commit appends the name of the JAR file to the exception message for >> when automatic module lists a non-existing provider class. > > src/java.base/share/classes/jdk/internal/module/ModulePath.java line 554: > >> 552:

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Alan Bateman
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. src/java.base/share/classes/jdk/internal/module/ModulePath.java line 554: > 552:

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Jorn Vernee
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. Marked as reviewed by jvernee (Reviewer). - PR:

Re: RFR: JDK-8262944: Improve exception message when automatic module lists provider class not in JAR file

2021-09-23 Thread Daniel Fuchs
On Thu, 16 Sep 2021 09:06:20 GMT, Christian Stein wrote: > This commit appends the name of the JAR file to the exception message for > when automatic module lists a non-existing provider class. The proposed change looks reasonable to me. - Marked as reviewed by dfuchs (Reviewer).