On Mon, 26 Apr 2021 14:55:57 GMT, Lance Andersen wrote:
> Hi Hamlin,
>
> The change looks fine. Please add the noreg-trivial change to the issue given
> there is not a test update for this so that you do not get pinged by a bot
Hi Lance, Thanks for reminding.
Thanks @LanceAndersen @naotoj
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
On Mon, 26 Apr 2021 02:36:54 GMT, Hamlin Li wrote:
>> code like below will create Deflater before null check, although it's not a
>> real mem leak, but it's better to do null check before new Deflater.
>>
>> try {
>> DeflaterOutputStream dos = new
> code like below will create Deflater before null check, although it's not a
> real mem leak, but it's better to do null check before new Deflater.
>
> try {
> DeflaterOutputStream dos = new DeflaterOutputStream(null);
> } catch (NullPointerException e) {
>