> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Thu, 5 Aug 2021 11:21:59 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux dis
On Fri, 6 Aug 2021 08:29:50 GMT, Severin Gehwolf wrote:
> This looks good to me now and passes tests on my cgroup v1 and cgroup v2
> setups.
Thanks for the review and approval .
Best regards, Matthias
-
PR: https://git.openjdk.java.net/jdk/pull/4518
On Thu, 5 Aug 2021 11:21:59 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux dis
On Thu, 5 Aug 2021 11:19:17 GMT, Matthias Baesken wrote:
>>> What do you think about accepting, when setting -1/unlimited, a high limit
>>> number like 20.000+ as well (and and a comment that on some setups
>>> unlimited means just "high number" but not unlimited?
>>
>> This seems most reasona
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Mon, 2 Aug 2021 11:42:33 GMT, Severin Gehwolf wrote:
> > What do you think about accepting, when setting -1/unlimited, a high limit
> > number like 20.000+ as well (and and a comment that on some setups
> > unlimited means just "high number" but not unlimited?
>
> This seems most reasonable
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Tue, 27 Jul 2021 10:25:22 GMT, Matthias Baesken wrote:
> What do you think about accepting, when setting -1/unlimited, a high limit
> number like 20.000+ as well (and and a comment that on some setups unlimited
> means just "high number" but not unlimited?
This seems most reasonable. I'd su
On Fri, 23 Jul 2021 12:32:04 GMT, Severin Gehwolf wrote:
> > Could this be some setting configured on your box that is picked up as an
> > additional limit ?
>
> Possibly. Not sure where to look, though.
I ask some local experts about that issue.
What do you think about accepting, when setting
On Fri, 23 Jul 2021 12:28:47 GMT, Severin Gehwolf wrote:
> Could this be some setting configured on your box that is picked up as an
> additional limit ?
Possibly. Not sure where to look, though.
-
PR: https://git.openjdk.java.net/jdk/pull/4518
On Fri, 23 Jul 2021 11:02:13 GMT, Matthias Baesken wrote:
> > No, I don't know what to do about it. All I can see it comes back with a
> > pids limit of `38019` when set to `-1`. It does seem like a bug or an
> > intentional setting so as to avoid fork bombs.
>
> Very strange indeed, I have do
On Fri, 23 Jul 2021 08:39:37 GMT, Severin Gehwolf wrote:
>
> No, I don't know what to do about it. All I can see it comes back with a pids
> limit of `38019` when set to `-1`. It does seem like a bug or an intentional
> setting so as to avoid fork bombs.
Very strange indeed, I have docker 20.
On Fri, 23 Jul 2021 06:49:15 GMT, Matthias Baesken wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor adjustments, handling of Unlimited
>
>> @MBaesken Thanks. We need a solution for [#4518
>> (comment)](ht
On Thu, 22 Jul 2021 12:18:20 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux di
On Thu, 22 Jul 2021 12:15:03 GMT, Matthias Baesken wrote:
>> Matthias Baesken has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>>
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Fri, 16 Jul 2021 06:14:07 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux di
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Thu, 15 Jul 2021 13:09:54 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux di
On Fri, 9 Jul 2021 13:53:27 GMT, Matthias Baesken wrote:
> > OK. Please also add a test on the hotspot side. You may want to add
> > relevant parts to `TestMisc.java`.
>
> Thanks for the suggestion, I will look into TestMisc.java .
I added some HS testing code in the latest commit.
Best regar
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Fri, 9 Jul 2021 13:42:15 GMT, Severin Gehwolf wrote:
> OK. Please also add a test on the hotspot side. You may want to add relevant
> parts to `TestMisc.java`.
Thanks for the suggestion, I will look into TestMisc.java .
-
PR: https://git.openjdk.java.net/jdk/pull/4518
On Fri, 9 Jul 2021 11:35:34 GMT, Matthias Baesken wrote:
> > This looks pretty good now. Looking forward to seeing container tests for
> > this new code.
>
> Hi Severin , I did some adjustments following your suggestions.
> I added docker based test coding for testing pids-limit (with limits an
On Tue, 29 Jun 2021 08:21:51 GMT, Severin Gehwolf wrote:
> This looks pretty good now. Looking forward to seeing container tests for
> this new code.
Hi Severin , I did some adjustments following your suggestions.
I added docker based test coding for testing pids-limit (with limits and also
wi
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Wed, 23 Jun 2021 13:37:59 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux di
On Wed, 23 Jun 2021 14:48:22 GMT, Severin Gehwolf wrote:
> > But I think that the testing needs to be enhanced (e.g. with some added
> > docker tests?). Do you have some good suggestions
> > where I could look at existing (docker?) tests and adjust those for the new
> > pids.max ?
>
> Have a l
On Wed, 23 Jun 2021 13:38:58 GMT, Matthias Baesken wrote:
> But I think that the testing needs to be enhanced (e.g. with some added
> docker tests?). Do you have some good suggestions
> where I could look at existing (docker?) tests and adjust those for the new
> pids.max ?
Have a look at `tes
On Wed, 23 Jun 2021 13:37:59 GMT, Matthias Baesken wrote:
>> Hello, please review this PR; it extend the OSContainer API in order to also
>> support the pids controller of cgroups.
>>
>> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
>> "memory" on some older Linux di
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids
> controller might not be t
On Thu, 17 Jun 2021 12:27:25 GMT, Matthias Baesken wrote:
> Hello, please review this PR; it extend the OSContainer API in order to also
> support the pids controller of cgroups.
>
> I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
> "memory" on some older Linux distros
Hello, please review this PR; it extend the OSContainer API in order to also
support the pids controller of cgroups.
I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct",
"memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids controller
might not be there (or not
33 matches
Mail list logo
