On Wed, 16 Feb 2022 21:39:20 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - Merge
On Wed, 16 Feb 2022 21:39:20 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains 10 commits:
>
> - Merge
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- Merge master
- fix test breakage from rename
- reformat test summary
-
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix test breakage from rename
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with three additional
commits since the last revision:
- reformat test summary
- reformat test summary
- improve test name and remove experimental test
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7448/files
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
More changes from feedback.
The javadoc is improved to reflect InvalidCallerException is thrown
On Tue, 15 Feb 2022 23:05:30 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Changes from feedback.
>>
>> - Copyright dates fixed
>> - IllegalCallerException thrown for no caller frame, and
On Tue, 15 Feb 2022 22:17:53 GMT, Tim Prinzing wrote:
>> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
>> null
>
> Tim Prinzing has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes from feedback.
>
> -
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Copyright dates fixed
- IllegalCallerException thrown for no caller f
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Build changes LGTM.
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7448
On Fri, 11 Feb 2022 23:25:44 GMT, Brent Christian wrote:
> Having a second thought, since this API expects to be called by a class
> loader, I think throwing `IllegalCallerException` to indicate this method is
> called by an illegal caller. This will need a CSR due to the spec change.
I think
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Yes, I like the IllegalCallerException.
-
PR: https://git.openjdk.java.net/jdk/pull/7448
On Fri, 11 Feb 2022 22:37:57 GMT, Mandy Chung wrote:
> Thanks for taking on these null caller issue.
>
> To give more context to this issue, the spec of
> `ClassLoader::isRegisteredAsParallelCapable` returns true if this class
> loader is registered as parallel capable, otherwise false. The cu
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Build change looks good.
-
Marked as reviewed by erikj (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7448
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Thanks for taking on these null caller issue.
To give more context to this issue, the spec of
`ClassLoader::isRegisteredAsParallelCapable` returns true if
JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is null
-
Commit messages:
- Merge branch 'master' into JDK-8281000
- JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
null
Changes: https://git.openjdk.java.net/jdk/pull/7448/files
17 matches
Mail list logo