Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-22 Thread liach
On Tue, 22 Mar 2022 12:56:02 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/runtime/Carrier.java line 574: >> >>> 572: try { >>> 573: Lookup lookup = MethodHandles.lookup(); >>> 574: return lookup.defineHiddenClass(bytes, false, >>>

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-22 Thread Jim Laskey
On Mon, 21 Mar 2022 18:02:07 GMT, ExE Boss wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 18 additional >> commits since

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-22 Thread Jim Laskey
On Tue, 22 Mar 2022 10:20:15 GMT, Daniel Fuchs wrote: >> Jim Laskey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 18 additional >> commits

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-22 Thread Jim Laskey
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote: >> We propose to provide a runtime anonymous carrier class object generator; >> java.lang.runtime.Carrier. This generator class is designed to share >> anonymous classes when shapes are similar. For example, if several clients >> require

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-22 Thread Daniel Fuchs
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote: >> We propose to provide a runtime anonymous carrier class object generator; >> java.lang.runtime.Carrier. This generator class is designed to share >> anonymous classes when shapes are similar. For example, if several clients >> require

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-21 Thread John Rose
On 21 Mar 2022, at 11:05, ExE Boss wrote: > Actually, this lookup object should probably be kept cached. +1. Good “cache”.

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-21 Thread ExE Boss
On Mon, 21 Mar 2022 14:24:30 GMT, Jim Laskey wrote: >> We propose to provide a runtime anonymous carrier class object generator; >> java.lang.runtime.Carrier. This generator class is designed to share >> anonymous classes when shapes are similar. For example, if several clients >> require

Re: RFR: JDK-8282798 java.lang.runtime.Carrier [v11]

2022-03-21 Thread Jim Laskey
> We propose to provide a runtime anonymous carrier class object generator; > java.lang.runtime.Carrier. This generator class is designed to share > anonymous classes when shapes are similar. For example, if several clients > require objects containing two integer fields, then Carrier will