Re: RFR: JDK-8287838: Update Float and Double to use snippets [v2]

2022-06-06 Thread Alan Bateman
On Mon, 6 Jun 2022 16:54:29 GMT, Joe Darcy wrote: >> src/java.base/share/classes/java/lang/Double.java line 683: >> >>> 681: * "[\\x00-\\x20]*");// Optional trailing "whitespace" >>> 682: * >>> 683: * if (Pattern.matches(fpRegex, myString)) // @link >>> substring="Pattern.

Re: RFR: JDK-8287838: Update Float and Double to use snippets [v2]

2022-06-06 Thread Joe Darcy
On Mon, 6 Jun 2022 05:29:24 GMT, Alan Bateman wrote: > One other thing you could do is link Pattern.matches in the snippet to the > matches method. Suggestion made in subsequent push; thanks. > src/java.base/share/classes/java/lang/Double.java line 683: > >> 681: * "[\\x00-\\x20]*"

Re: RFR: JDK-8287838: Update Float and Double to use snippets [v2]

2022-06-06 Thread Alan Bateman
On Mon, 6 Jun 2022 20:37:07 GMT, Joe Darcy wrote: >> Various code blocks in Float and Double would be better as snippets. > > Joe Darcy has updated the pull request incrementally with two additional > commits since the last revision: > > - Use idiom for shorter lines > - Respond to review fee

Re: RFR: JDK-8287838: Update Float and Double to use snippets [v2]

2022-06-06 Thread Joe Darcy
> Various code blocks in Float and Double would be better as snippets. Joe Darcy has updated the pull request incrementally with two additional commits since the last revision: - Use idiom for shorter lines - Respond to review feedback. - Changes: - all: https://git.openjdk.jav