Re: RFR: More cleanup patches

On Fri, Mar 30, 2018 at 3:53 AM, Alan Bateman wrote: > > 8200125: Fix some classloader/module typos >> http://cr.openjdk.java.net/~martin/webrevs/jdk/loader-typos/ >> https://bugs.openjdk.java.net/browse/JDK-8200125 >> > Most of these are okay but you've dropped the text

RFR: More cleanup patches

Hi Martin, as soon as the changes for 8199800: Optimize Boolean.parseBoolean(String) are merged we could replace code snippets like if (aValue.toUpperCase().equals("TRUE")) { value = Boolean.TRUE; } else { value = Boolean.FALSE; } with value = Boolean.parseBoolean(aValue); See

Re: RFR: More cleanup patches

On 3/31/18 12:29 AM, Martin Buchholz wrote: On Fri, Mar 30, 2018 at 4:31 AM, mandy chung > wrote: For this change, I am okay with most of the changes except I prefer the while loop to the for-loop with the local variable

Re: RFR: More cleanup patches

Maybe I'm starting to understand. // attempt to load class in module defined to this loader assert loadedModule.loader() == this; return findClassInModuleOrNull(loadedModule, cn); Precondition of calling findClassInModuleOrNull is that loadedModule.loader() ==

Re: RFR: More cleanup patches

On Fri, Mar 30, 2018 at 3:53 AM, Alan Bateman wrote: > On 30/03/2018 02:55, Martin Buchholz wrote: > >> >> 8200125: Fix some classloader/module typos >> http://cr.openjdk.java.net/~martin/webrevs/jdk/loader-typos/ >> https://bugs.openjdk.java.net/browse/JDK-8200125 >> >

Re: RFR: More cleanup patches

On Fri, Mar 30, 2018 at 4:55 AM, mandy chung wrote: > > > On 3/30/18 7:38 PM, Peter Levart wrote: > > > > On 03/30/2018 01:31 PM, mandy chung wrote: > > > > On 3/30/18 6:53 PM, Alan Bateman wrote: > > > > 8200134: Improve ModuleHashesBuilder >

Re: RFR: More cleanup patches

On Fri, Mar 30, 2018 at 4:31 AM, mandy chung wrote: > > For this change, I am okay with most of the changes except I prefer the > while loop to the for-loop with the local variable declaration. > I prefer the idiom with the declaration in the for loop ("keep variable

Re: RFR: More cleanup patches

On 3/30/18 7:38 PM, Peter Levart wrote: On 03/30/2018 01:31 PM, mandy chung wrote: On 3/30/18 6:53 PM, Alan Bateman wrote: 8200134: Improve ModuleHashesBuilder http://cr.openjdk.java.net/~martin/webrevs/jdk/ModuleHashesBuilder/ https://bugs.openjdk.java.net/browse/JDK-8200134 I

Re: RFR: More cleanup patches

On 03/30/2018 01:31 PM, mandy chung wrote: On 3/30/18 6:53 PM, Alan Bateman wrote: 8200134: Improve ModuleHashesBuilder http://cr.openjdk.java.net/~martin/webrevs/jdk/ModuleHashesBuilder/ https://bugs.openjdk.java.net/browse/JDK-8200134 I suspect Mandy will want to look at this one. We

Re: RFR: More cleanup patches

On 3/30/18 6:53 PM, Alan Bateman wrote: 8200134: Improve ModuleHashesBuilder http://cr.openjdk.java.net/~martin/webrevs/jdk/ModuleHashesBuilder/ https://bugs.openjdk.java.net/browse/JDK-8200134 I suspect Mandy will want to look at this one. We also need to decide if there is a better place

Re: RFR: More cleanup patches

On 30/03/2018 02:55, Martin Buchholz wrote: 8199800: Optimize Boolean.parseBoolean(String) http://cr.openjdk.java.net/~martin/webrevs/jdk/Boolean-parseBoolean/ https://bugs.openjdk.java.net/browse/JDK-8199800 Looks okay. 8200364: Remove unnecessary boxing via primitive wrapper valueOf(String)

Re: RFR: More cleanup patches

Hi Martin, On 30/03/2018 02:55, Martin Buchholz wrote: 8200364: Remove unnecessary boxing via primitive wrapper valueOf(String) methods http://cr.openjdk.java.net/~martin/webrevs/jdk/valueOf-boxing/ https://bugs.openjdk.java.net/browse/JDK-8200364 The changes above look fine to me. I'll let

RFR: More cleanup patches

8199800: Optimize Boolean.parseBoolean(String) http://cr.openjdk.java.net/~martin/webrevs/jdk/Boolean-parseBoolean/ https://bugs.openjdk.java.net/browse/JDK-8199800 8200364: Remove unnecessary boxing via primitive wrapper valueOf(String) methods