Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-04 Thread Jonathan Gibbons
On 5/3/17 7:49 PM, Martin Buchholz wrote: --- Yes, "striped" is a much better name than "altrows". "striped-tables" as you suggest may be better. Choose your names carefully - we can't change them in the future. --- Well, we can, ... but ... A goal of creating specification(s) for the

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-04 Thread Jonathan Gibbons
On 5/3/17 7:49 PM, Martin Buchholz wrote: w3.org doc seems to suggest we should only be defining table styles with borders. https://www.w3.org/TR/html5/tabular-data.html#attr-table-border """Tables should not be used as layout aids. """ """User agents, especially those tha

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Martin Buchholz
Jonathan Gibbons for "css style czar"! --- I checked the tables at http://cr.openjdk.java.net/~jjg/8179479-8179592/api/java/util/concurrent/BlockingDeque.html They look perfectly fine, although I feel a twinge of non-collapsed-border-nostalgia. --- Yes, "striped" is a much better name than "al

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Jonathan Gibbons
With my javadoc-tool-developer hat on, I'd like to get out of the business of jdk-style-owner, or at least identify that as a distinct hat. :-) Kumar has identified a problem with the styles as currently defined ... you cannot easily embed a table with a default style inside a table with an e

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Martin Buchholz
Jon, I am happy for you to own the html5 style for the entire javadoc; consistency wins; my comments are only suggestions and I'm no html or css expert. On Wed, May 3, 2017 at 5:03 PM, Jonathan Gibbons < jonathan.gibb...@oracle.com> wrote: > > > On 05/03/2017 04:39 PM, Martin Buchholz wrote: > >

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Jonathan Gibbons
On 05/03/2017 04:39 PM, Martin Buchholz wrote: Thanks, Jon. For the Deque/Queue tables - * + * I expected that we would modify these to which rendered alright and is compliant (although "border" is a weird boolean) and makes the "border intent" clear to humans and to browsers. THIS IS JA

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Martin Buchholz
Thanks, Jon. For the Deque/Queue tables - * + * I expected that we would modify these to which rendered alright and is compliant (although "border" is a weird boolean) and makes the "border intent" clear to humans and to browsers. THIS IS JAVA, so I'd prefer more verbose meaningful names for

Re: RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Joseph D. Darcy
Hi Jon, The changes in the java.lang and java.math packages look fine. Cheers, -Joe On 5/3/2017 3:06 PM, Jonathan Gibbons wrote: This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5 ta

RFR: Update tables in java.base to be HTML5-friendly.

2017-05-03 Thread Jonathan Gibbons
This is a review request for two co-dependent fixes. JDK-8179592: Update tables in java.base to be HTML 5-friendly. JDK-8179479: Add new styles to enable HTML 5 tables In doc comments, some of the HTML 4.01 attributes for tables are no longer available in HTML 5, and CSS should be used instead.