Re: RFR: removing dead code from jar tool

ar 2020 18:04 >> To: Sean Mullan >> Cc: core-libs-dev@openjdk.java.net >> Subject: Re: RFR: removing dead code from jar tool >> >> sigh it is being removed it appears by the mail server >> >> I placed a copy here: http://cr.openjdk.java.net/~lancea/JDK-8

RE: RFR: removing dead code from jar tool

sen > Sent: Freitag, 28. Februar 2020 18:04 > To: Sean Mullan > Cc: core-libs-dev@openjdk.java.net > Subject: Re: RFR: removing dead code from jar tool > > sigh it is being removed it appears by the mail server > > I placed a copy here: http://cr.openjdk

Re: RFR: removing dead code from jar tool

sigh it is being removed it appears by the mail server I placed a copy here: http://cr.openjdk.java.net/~lancea/JDK-8230117.patch > On Feb 28, 2020, at 12:00 PM, Lance Andersen > wrote: > > Here it is again > >> On Feb 28, 2020, at 11:07

Re: RFR: removing dead code from jar tool

Here it is again > On Feb 28, 2020, at 11:07 AM, Sean Mullan wrote: > > I think you forgot to attach the patch. > > --Sean > > On 2/28/20 2:28 AM, Adam Sotona wrote: >> Hi, >> I would like to ask for review of the attached patch removing dead code from >> jar tool >> Class files sun.tools.jar

Re: RFR: removing dead code from jar tool

I think you forgot to attach the patch. --Sean On 2/28/20 2:28 AM, Adam Sotona wrote: Hi, I would like to ask for review of the attached patch removing dead code from jar tool Class files sun.tools.jar.Manifest and sun.tools.jar.SignatureFile appear to be dead code and should be removed. Buil

Re: RFR: removing dead code from jar tool

Thank you, Adam > On 28 Feb 2020, at 12:57, Lance Andersen wrote: > > I think this looks OK. I did a search and did not find any usages so I > suspect this should be safe to do. > > Best > Lancee > >> On Feb 28, 2020, at 5:28 AM, Adam Sotona > > wrote: >> >>

Re: RFR: removing dead code from jar tool

I think this looks OK. I did a search and did not find any usages so I suspect this should be safe to do. Best Lancee > On Feb 28, 2020, at 5:28 AM, Adam Sotona wrote: > > Hi, > I would like to ask for review of the attached patch removing dead code from > jar tool > Class files sun.tools.ja

RFR: removing dead code from jar tool

Hi, I would like to ask for review of the attached patch removing dead code from jar tool Class files sun.tools.jar.Manifest and sun.tools.jar.SignatureFile appear to be dead code and should be removed. Build with the patch passes all Tier1, Tier2 and Tier3 tests. Thank you, Adam