Re: RFR (3rd): 8023524: Mechanism to dump generated lambda classes / log lambda code generation

2013-09-27 Thread Henry Jen
On Sep 26, 2013, at 4:01 PM, Mandy Chung mandy.ch...@oracle.com wrote: Hi Henry, On 9/25/2013 12:37 AM, Henry Jen wrote: Hi, Please review the update webrev at http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/ The doPrivileged block looks okay. It'd be good to limit

Re: RFR (3rd): 8023524: Mechanism to dump generated lambda classes / log lambda code generation

2013-09-26 Thread Mandy Chung
Hi Henry, On 9/25/2013 12:37 AM, Henry Jen wrote: Hi, Please review the update webrev at http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/ The doPrivileged block looks okay. It'd be good to limit privileges by calling the doPrivileged method with a specific set of Permissions. In

Re: RFR (3rd): 8023524: Mechanism to dump generated lambda classes / log lambda code generation

2013-09-25 Thread Henry Jen
Hi, Please review the update webrev at http://cr.openjdk.java.net/~henryjen/ccc/8023524/2/webrev/ In this revision, I moved out code for dumping the generated class files into a separate class as Remi suggested, so that the code is only loaded if the property is set. (Verified with