Re: RFR (JAXP): 8068839: newDuration(x) produces incorrect outputs for some values of x

2015-12-11 Thread Lance Andersen
Hi Joe, I think this looks OK. My only suggestion is I am not a fan of creating a one-off type of test vs integrating if at all possible a test such as this into existing test(s). The reason is it can get out of control the number of one off tests and makes it a bit harder to know the coverag

Re: RFR (JAXP): 8068839: newDuration(x) produces incorrect outputs for some values of x

2015-12-11 Thread Roger Riggs
Hi Joe, Looks fine. Roger On 12/11/2015 12:54 PM, huizhe wang wrote: This is a fix for an edge case. All tests passed after the fix. JBS: https://bugs.openjdk.java.net/browse/JDK-8068839 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8068839/webrev/ Thanks, Joe

RFR (JAXP): 8068839: newDuration(x) produces incorrect outputs for some values of x

2015-12-11 Thread huizhe wang
This is a fix for an edge case. All tests passed after the fix. JBS: https://bugs.openjdk.java.net/browse/JDK-8068839 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8068839/webrev/ Thanks, Joe