Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-27 Thread Alan Bateman
On 26/11/2013 22:13, huizhe wang wrote: Ah, I missed that. I took it for granted that since ServiceLoader.load(service) uses TCCL, load(service, null) would use TCCL. I've updated the webrev now: http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ It looks good now but I'm

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-27 Thread huizhe wang
On 11/27/2013 2:03 AM, Alan Bateman wrote: On 26/11/2013 22:13, huizhe wang wrote: Ah, I missed that. I took it for granted that since ServiceLoader.load(service) uses TCCL, load(service, null) would use TCCL. I've updated the webrev now:

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread Alan Bateman
On 25/11/2013 21:51, huizhe wang wrote: Hi, This is a patch to fix an error in StAX factories' newFactory(String factoryId, ClassLoader classLoader). In the 3 step of the documentation, it should have stated that the specified ClassLoader is used.

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread huizhe wang
Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ Thanks, Joe On 11/26/2013 8:09 AM, Alan Bateman wrote: On 25/11/2013 21:51, huizhe wang wrote: Hi, This is a patch to fix an error in StAX

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread Alan Bateman
On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling the null case correctly? It is spec'ed to use the TCCL but it looks like it's going

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread roger riggs
Hi, I looked at that twice also.java.time had a similar situation. To get to the TCCL you need to call ServiceLoader.load(type). The FactoryFinder:348 findServiceProvider method should test if cl == null and call the original ServiceLoader function. Roger On 11/26/2013 4:37 PM, Alan

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread huizhe wang
On 11/26/2013 1:37 PM, Alan Bateman wrote: On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling the null case correctly? It is spec'ed to use

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread Daniel Fuchs
On 11/26/13 11:13 PM, huizhe wang wrote: On 11/26/2013 1:37 PM, Alan Bateman wrote: On 26/11/2013 18:38, huizhe wang wrote: Hi all, Here's revised webrev, as Alan suggested, including the implementation. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/8028822/webrev/ So is this handling

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread huizhe wang
On 11/26/2013 1:59 PM, roger riggs wrote: Hi, I looked at that twice also.java.time had a similar situation. To get to the TCCL you need to call ServiceLoader.load(type). The FactoryFinder:348 findServiceProvider method should test if cl == null and call the original ServiceLoader

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-26 Thread Lance Andersen - Oracle
looks OK Joe On Nov 26, 2013, at 5:27 PM, huizhe wang wrote: On 11/26/2013 1:59 PM, roger riggs wrote: Hi, I looked at that twice also.java.time had a similar situation. To get to the TCCL you need to call ServiceLoader.load(type). The FactoryFinder:348 findServiceProvider method

RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-25 Thread huizhe wang
Hi, This is a patch to fix an error in StAX factories' newFactory(String factoryId, ClassLoader classLoader). In the 3 step of the documentation, it should have stated that the specified ClassLoader is used. http://cr.openjdk.java.net/~joehw/jdk8/jaxp16MR/webrev/ Thanks, Joe

Re: RFR (JAXP) 8028822 : Error in the documentation for newFactory method of the javax.xml.stream factories

2013-11-25 Thread Lance @ Oracle
+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad On Nov 25, 2013, at 4:51 PM, huizhe wang huizhe.w...@oracle.com wrote: Hi, This is a patch to fix an error in