Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-28 Thread Peter Levart
On 03/28/2013 04:34 AM, Mandy Chung wrote: Hi Peter, On 3/21/2013 11:47 AM, Peter Levart wrote: ... I have seen a utility that uses it to establish the context (package and ClassLoader) of where to start searching for resources for GUI components construction. And a utility that wraps

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-27 Thread Mandy Chung
Hi Peter, On 3/21/2013 11:47 AM, Peter Levart wrote: ... I have seen a utility that uses it to establish the context (package and ClassLoader) of where to start searching for resources for GUI components construction. And a utility that wraps Class.forName(String) - specifying

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-22 Thread Christian Thalinger
On Mar 19, 2013, at 6:02 PM, Christian Thalinger christian.thalin...@oracle.com wrote: On Mar 19, 2013, at 5:21 PM, John Rose john.r.r...@oracle.com wrote: On Mar 14, 2013, at 8:31 PM, Christian Thalinger christian.thalin...@oracle.com wrote: [This is the HotSpot part of JEP 176]

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-21 Thread Mandy Chung
Hi Peter, On 3/20/2013 2:33 AM, Peter Levart wrote: Hi, If I understand correctly, sun.reflect.Reflection.getCallerClass(int) will not be usable by non-system code any more. I know it's not a public API, but it's useful in some situations (not security-related) and there's no public API for

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-21 Thread Peter Levart
On 03/21/2013 07:11 PM, Mandy Chung wrote: Hi Peter, On 3/20/2013 2:33 AM, Peter Levart wrote: Hi, If I understand correctly, sun.reflect.Reflection.getCallerClass(int) will not be usable by non-system code any more. I know it's not a public API, but it's useful in some situations (not

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-20 Thread Peter Levart
Hi, If I understand correctly, sun.reflect.Reflection.getCallerClass(int) will not be usable by non-system code any more. I know it's not a public API, but it's useful in some situations (not security-related) and there's no public API for that functionality. Is there a reason to not

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-19 Thread Mandy Chung
I do a partial review in particular to make sure the jdk and hotspot change are in sync. javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the same value. Should they be different? 1057 MN_CALLER_SENSITIVE = 0x0010, // @CallerSensitive annotation detected

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-19 Thread Christian Thalinger
On Mar 19, 2013, at 1:14 PM, Mandy Chung mandy.ch...@oracle.com wrote: I do a partial review in particular to make sure the jdk and hotspot change are in sync. javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the same value. Should they be different? 1057

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-19 Thread John Rose
On Mar 19, 2013, at 1:14 PM, Mandy Chung mandy.ch...@oracle.com wrote: javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the same value. Should they be different? 1057 MN_CALLER_SENSITIVE = 0x0010, // @CallerSensitive annotation detected 1061

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-19 Thread Christian Thalinger
On Mar 19, 2013, at 5:21 PM, John Rose john.r.r...@oracle.com wrote: On Mar 14, 2013, at 8:31 PM, Christian Thalinger christian.thalin...@oracle.com wrote: [This is the HotSpot part of JEP 176] http://cr.openjdk.java.net/~twisti/7198429 7198429: need checked categorization of

Re: RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-19 Thread Mandy Chung
On 3/19/2013 5:29 PM, Christian Thalinger wrote: On Mar 19, 2013, at 1:14 PM, Mandy Chung mandy.ch...@oracle.com wrote: I do a partial review in particular to make sure the jdk and hotspot change are in sync. javaClasses.hpp - MN_CALLER_SENSITIVE and MN_SEARCH_SUPERCLASSES have the same

RFR (M): 7198429: need checked categorization of caller-sensitive methods in the JDK

2013-03-14 Thread Christian Thalinger
[This is the HotSpot part of JEP 176] http://cr.openjdk.java.net/~twisti/7198429 7198429: need checked categorization of caller-sensitive methods in the JDK Reviewed-by: More information in JEP 176: http://openjdk.java.net/jeps/176 src/share/vm/ci/ciMethod.cpp src/share/vm/ci/ciMethod.hpp