Re: RFR (S) 8226831 : Use Objects.equals() when appropriate

2019-08-27 Thread Ivan Gerasimov
Thank you Roger and Brian! The fix has been pushed. With kind regards, Ivan On 8/27/19 1:12 PM, Brian Burkhalter wrote: Hi Ivan, +1 Brian On Aug 27, 2019, at 12:41 PM, Roger Riggs wrote: Hi Ivan, These look fine. Regards, Roger On 8/27/19 2:21 PM, Ivan Gerasimov wrote: Hello! nul

Re: RFR (S) 8226831 : Use Objects.equals() when appropriate

2019-08-27 Thread Brian Burkhalter
Hi Ivan, +1 Brian > On Aug 27, 2019, at 12:41 PM, Roger Riggs wrote: > > Hi Ivan, > > These look fine. > > Regards, Roger > > > On 8/27/19 2:21 PM, Ivan Gerasimov wrote: >> Hello! >> >> null-aware comparison of Objects is widely used, so it's tempting to use >> Objects.equals for that. >

Re: RFR (S) 8226831 : Use Objects.equals() when appropriate

2019-08-27 Thread Roger Riggs
Hi Ivan, These look fine. Regards, Roger On 8/27/19 2:21 PM, Ivan Gerasimov wrote: Hello! null-aware comparison of Objects is widely used, so it's tempting to use Objects.equals for that. Unfortunately, there are concerns w.r.t performance (see JDK-8015417), so it seems to better avoid t

RFR (S) 8226831 : Use Objects.equals() when appropriate

2019-08-27 Thread Ivan Gerasimov
Hello! null-aware comparison of Objects is widely used, so it's tempting to use Objects.equals for that. Unfortunately, there are concerns w.r.t performance (see JDK-8015417), so it seems to better avoid this kind of refactoring in the performance critical code. Please find the webrev with