Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Ivan, > On 4 Oct 2019, at 03:00, Ivan Gerasimov wrote: > > ... > > I've adopted your suggested changes and the test: > http://cr.openjdk.java.net/~igerasim/8230407/02/webrev/ > LGTM. > CSR was also updated accordingly: >

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hi Chris! On 10/3/19 8:05 AM, Chris Hegarty wrote: Ivan, On 3 Oct 2019, at 04:41, Ivan Gerasimov wrote: ... So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805 to cover the addition of @throws paragraph in the javadoc of SocketPermission. I would really appreciate it, if

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Thanks Peter, your variant looks cute! Let's keep this code in mind as a candidate for refactoring once the switch expression will make its way to the standard. I would hesitate to allow using experimental features in building the JDK just for that code :) With kind regards, Ivan On

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Ivan, > On 3 Oct 2019, at 04:41, Ivan Gerasimov wrote: > > ... > > So, I filed CSR: https://bugs.openjdk.java.net/browse/JDK-8231805 to cover > the addition of @throws paragraph in the javadoc of SocketPermission. > > I would really appreciate it, if someone helped to review it. > Since

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hi Ivan, On 10/1/19 10:26 PM, Ivan Gerasimov wrote: Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Thank you Joe for checking it! On 10/2/19 4:38 PM, Joe Darcy wrote: Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Sigh.  I was hopping it'll be a quick fix :-) So, I filed CSR:

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hello, At least from a quick reading, either the spec change or the behavior change would seem to merit a CSR. Cheers, -Joe On 10/2/2019 4:26 PM, Ivan Gerasimov wrote: Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hi Chris! Thank you very much for review! I agree that it makes sense to update the javadoc for consistency. I don't think CSR is required in this case, is it? (IAE is unchecked anyway, and the fix doesn't really change the behavior.) Here's the updated webrev:

Re: RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Ivan, On 01/10/2019 21:26, Ivan Gerasimov wrote: Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current

RFR (S) 8230407 : SocketPermission and FilePermission action list allows leading comma

Hello! The constructors of SocketPermission and FilePermission expect a String argument with comma-separated list of actions. If the list is malformed, then the constructors throw IllegalArgumentException. It turns out that the current implementation fails to throw IAE if the list starts