RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Christian Thalinger
http://cr.openjdk.java.net/~twisti/6771058 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp Reviewed-by: This test can fail if finalizer of Basic is not called for some reason. It happens in compiled mode if compilation is more slow than execution of the main loop. The

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Christian Thalinger
On Oct 18, 2012, at 3:31 PM, Mandy Chung mandy.ch...@oracle.com wrote: Hi Christian, Thanks for taking on this bug. Sure. I'm trying to get HotSpot nightly failures down. Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Mandy Chung
Hi Christian, Thanks for taking on this bug. Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I wonder how long the test will take to complete/pass? With your fix, how many GC does it

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread Mandy Chung
On 10/18/2012 3:37 PM, Christian Thalinger wrote: Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I wonder how long the test will take to complete/pass? Around 14 GCs (runtime with

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread David Holmes
Hi Chris, On 19/10/2012 8:37 AM, Christian Thalinger wrote: On Oct 18, 2012, at 3:31 PM, Mandy Chungmandy.ch...@oracle.com wrote: Just curious - the test runs with a max of 10 GCs. You reproduced this bug on a slower machine with fastdebug build. If you increase the max number of GCs, I

Re: RFR (XXS): 6771058: TEST_BUG: java/lang/ref/Basic.java may fail with -server -Xcomp

2012-10-18 Thread David Holmes
Hi Martin, On 19/10/2012 10:58 AM, Martin Buchholz wrote: http://code.google.com/p/guava-libraries/source/browse/guava-testlib/src/com/google/common/testing/GcFinalization.java That code uses runFinalization in places which means it is not exercising the primary finalization mechanism. But