Re: RFR : 7095856: OutputStreamHook doesn't handle null values

2014-07-01 Thread Mark Sheppard
Hi Sean, fix looks good .. surprised to see that GF has been modified to use HashMap and not the JDK wasn't!! In anycase this should solve a few other interop issues WRT the test, I wonder if it is more appropriate to use the javax.rmi.CORBA.Util class to obtain the ValueHandler rather

Re: RFR : 7095856: OutputStreamHook doesn't handle null values

2014-07-01 Thread Seán Coffey
Hey Mark, thanks for the review. Yes - that's a better way to obtain the valueHandler - will make the change and push shortly. regards, Sean. On 01/07/14 12:41, Mark Sheppard wrote: Hi Sean, fix looks good .. surprised to see that GF has been modified to use HashMap and not the JDK

Re: RFR : 7095856: OutputStreamHook doesn't handle null values

2014-06-27 Thread Lance Andersen
looks fine Sean On Jun 27, 2014, at 8:35 AM, Seán Coffey sean.cof...@oracle.com wrote: Looking for a review around this CORBA issue. bug report : https://bugs.openjdk.java.net/browse/JDK-7095856 webrev : http://cr.openjdk.java.net/~coffeys/webrev.7095856/ Null values cause issue when