Re: RFR : 8010948 : Add conversion functional interfaces

2013-04-10 Thread Mike Duigou
I have added two @see to every interface, the reverse function and the function converting from the other primitive type to the same type. ie. in IntToDoubleFunction I add @see for LongToDoubleFunction and DoubleToIntFunction. Mike On Apr 9 2013, at 16:14 , Paul Benedict wrote: Mike, It

Re: RFR : 8010948 : Add conversion functional interfaces

2013-04-09 Thread Mike Duigou
Any further comment on these? Technically they are adequately reviewed as I have reviewed them and am submitting them on behalf of Brian Goetz. I would prefer to know that at least one other set of eyes has looked at them though. Mike On Apr 3 2013, at 17:00 , Mike Duigou wrote: Hello all;

RFR : 8010948 : Add conversion functional interfaces

2013-04-09 Thread Paul Benedict
Mike, It would be nice if the class javadocs would have @see tags to classes in the same family. For example, DoubleToIntFunction could have a @see to DoubleToLongFunction, etc. This way a developer viewing of one class can easily figure out which close cousins exist. Paul

Re: RFR : 8010948 : Add conversion functional interfaces

2013-04-09 Thread David Holmes
On 10/04/2013 9:07 AM, Mike Duigou wrote: Any further comment on these? Technically they are adequately reviewed as I have reviewed them and am submitting them on behalf of Brian Goetz. I would prefer to know that at least one other set of eyes has looked at them though. I looked - no

RFR : 8010948 : Add conversion functional interfaces

2013-04-03 Thread Mike Duigou
Hello all; Another set of functional interfaces for review for the soon-to-be-arriving-in-TL-repo lambda libraries. http://cr.openjdk.java.net/~mduigou/JDK-8010948/0/webrev/ These interfaces are Functions between the core primitive types (double, int, long) used by the lambda libraries.