Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-08 Thread Joe Wang
: Freitag, November 8, 2019 11:14 AM An: Joe Wang Cc: core-libs-dev Betreff: Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory Hi Joe, Fix looks OK to me , but i am not able to understand how come "NamespaceMappings" instance can increase memory uses from (20M

Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-08 Thread Bernd Eckenfels
[14/java.xml] 8233686: XML transformer uses excessive amount of memory Hi Joe, Fix looks OK to me , but i am not able to understand how come "NamespaceMappings" instance can increase memory uses from (20MB to 140MB ). Current scope of "ns" is "case Node.ELEMENT_NODE:&quo

Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-08 Thread Vyom Tiwari
Hi Joe, Fix looks OK to me , but i am not able to understand how come "NamespaceMappings" instance can increase memory uses from (20MB to 140MB ). Current scope of "ns" is "case Node.ELEMENT_NODE:" block and "NamespaceMapping" seems to be very lightweight class. Thanks, Vyom On Fri, Nov

Re: RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-07 Thread Lance Andersen
Looks OK Joe. > On Nov 7, 2019, at 2:01 PM, Joe Wang wrote: > > Please review a quick fix that reduces unnecessary object allocations. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8233686 > webrev: http://cr.openjdk.java.net/~joehw/jdk14/8233686/webrev/ > > Thanks, > Joe >

RFR [14/java.xml] 8233686: XML transformer uses excessive amount of memory

2019-11-07 Thread Joe Wang
Please review a quick fix that reduces unnecessary object allocations. JBS: https://bugs.openjdk.java.net/browse/JDK-8233686 webrev: http://cr.openjdk.java.net/~joehw/jdk14/8233686/webrev/ Thanks, Joe