Re: RFR [6961766]: PrintStream.write() should flush at most once

2013-08-09 Thread Ivan Gerasimov
Hello David! On 08.08.2013 6:18, David Holmes wrote: Hi Ivan, On 8/08/2013 3:53 AM, Ivan Gerasimov wrote: Hello David! Thanks for review. Yes - this is NOT A BUG this is the spec for this class: Optionally, a PrintStream can be created so as to flush automatically; this means that the

Re: RFR [6961766]: PrintStream.write() should flush at most once

2013-08-07 Thread David Holmes
Ivan, On 7/08/2013 3:08 PM, Alan Bateman wrote: On 06/08/2013 09:38, Ivan Gerasimov wrote: Hello everybody! Would you please review a simple fix, suggested by someone on bugs.sun.com? j.i.PrintStream#write(char[]) calls out.flush() on each '\n' character found in the array. It's sufficient

Re: RFR [6961766]: PrintStream.write() should flush at most once

2013-08-07 Thread Ivan Gerasimov
Hello David! Thanks for review. Yes - this is NOT A BUG this is the spec for this class: Optionally, a PrintStream can be created so as to flush automatically; this means that the flush method is automatically invoked after a byte array is written, one of the println methods is invoked, or

Re: RFR [6961766]: PrintStream.write() should flush at most once

2013-08-07 Thread David Holmes
Hi Ivan, On 8/08/2013 3:53 AM, Ivan Gerasimov wrote: Hello David! Thanks for review. Yes - this is NOT A BUG this is the spec for this class: Optionally, a PrintStream can be created so as to flush automatically; this means that the flush method is automatically invoked after a byte array

RFR [6961766]: PrintStream.write() should flush at most once

2013-08-06 Thread Ivan Gerasimov
Hello everybody! Would you please review a simple fix, suggested by someone on bugs.sun.com? j.i.PrintStream#write(char[]) calls out.flush() on each '\n' character found in the array. It's sufficient to do it only once. BUGURL: http://bugs.sun.com/view_bug.do?bug_id=6961766 WEBREV:

Re: RFR [6961766]: PrintStream.write() should flush at most once

2013-08-06 Thread Alan Bateman
On 06/08/2013 09:38, Ivan Gerasimov wrote: Hello everybody! Would you please review a simple fix, suggested by someone on bugs.sun.com? j.i.PrintStream#write(char[]) calls out.flush() on each '\n' character found in the array. It's sufficient to do it only once. One thing to check is