On 4 Jun 2015, at 15:28, Paul Sandoz wrote:
> On Jun 4, 2015, at 4:09 PM, Chris Hegarty wrote:
>> On 4 Jun 2015, at 13:37, Paul Sandoz wrote:
>>
>>> ...
>>> If you wanna go the extra mile it's useful for the data provider to supply
>>> a string description argument summarizing the test data.
On Jun 4, 2015, at 4:09 PM, Chris Hegarty wrote:
> On 4 Jun 2015, at 13:37, Paul Sandoz wrote:
>
>> ...
>> If you wanna go the extra mile it's useful for the data provider to supply a
>> string description argument summarizing the test data.
>
> Added.
>
I did not mean:
> +@DataProvider
Thanks for the reviews.
On 4 Jun 2015, at 13:59, Ivan Gerasimov wrote:
> Wouldn't it cause the additional error message be printed _before_ the line
> 'test:.. : failure' ?
> I guess, It may look confusing.
>
> Would it make sense to re-throw the exception with this additional message
> i
Hi Chris!
Wouldn't it cause the additional error message be printed _before_ the
line 'test:.. : failure' ?
I guess, It may look confusing.
Would it make sense to re-throw the exception with this additional
message instead?
+try {
+assertEquals(actual, expected, "");
On Jun 4, 2015, at 12:54 PM, Chris Hegarty wrote:
> This is a review request to add better test failure output to
> jdk/test/java/util/Arrays/ParallelPrefix.java
>
Looks ok.
Printing the content should give some clues, but i expect it's only with some
focused repeated execution on an appro
This is a review request to add better test failure output to
jdk/test/java/util/Arrays/ParallelPrefix.java
This test has been seen to fail occasionally on recent JDK 9 builds. It fails
with a message similar to:
...
test ParallelPrefix.testParallelPrefixForInt([I@47a7a8ef, 1365, 2730,
Paralle
