Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

Thanks! the comments in ValueBoxGen24 are somewhat cryptic to me at least Yes, indeed... Roger mentioned that these may be some (outdated?) bug tracker references, so I prefer not to touch them; just remove the angle brackets to avoid warnings. Regards, Alexander On 05.05.2015 21:25, Lance

RFR [9] 8079342: some docs cleanup for CORBA - part 2

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8079342/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8079342 Just some HTML markup fix for CORBA. Thanks, Alexander

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

But yes, for 'writeValue' it could be renamed without any thoughts, thanks... On 05.05.2015 18:41, alexander stepanov wrote: Hello Lance, It just seemed to be less hazardous. E.g., method 'readValue' (in ValueHandlerImpl) contains inner variable 'in' and parameter '_in' being documented

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

Hi Alexander, Thank you, I guess I am not a fan of _variableName in the public javadocs as it is not something we normally see. Understand less is more, especially with CORBA. On May 5, 2015, at 11:41 AM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello Lance, It just

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

Hi Alexander, I just started to look at this and have a question: /** * Writes the value to the stream using java semantics. - * @param out The stream to write the value to + * @param _out The stream to write the value to * @param value The value to be written to the stream

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

Hello Lance, It just seemed to be less hazardous. E.g., method 'readValue' (in ValueHandlerImpl) contains inner variable 'in' and parameter '_in' being documented (also, '_sender' - 'sender'). But of course the names could be swapped, if desired. I lazily preferred not to touch the code

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

The changes seem reasonable those the comments in ValueBoxGen24 are somewhat cryptic to me at least :-) On May 5, 2015, at 12:30 PM, alexander stepanov alexander.v.stepa...@oracle.com wrote: _variableName in the public javadocs Please see

Re: RFR [9] 8079342: some docs cleanup for CORBA - part 2

_variableName in the public javadocs Please see http://cr.openjdk.java.net/~avstepan/8079342/webrev.00/src/java.corba/share/classes/com/sun/corba/se/impl/io/ValueHandlerImpl.java.udiff.html (please update the page as I didn't prepare a new webrev). Hopefully that do not harm the code...