Re: RFR [9] 8080422: some docs cleanup for core libs

Hi Alexander, Thanks for these needed cleanups; a few corrections below. 1) src/java.base/share/classes/jdk/internal/util/xml/impl/Parser.java: The grammar *which *this method can read is can remove the 'which' 2) src/java.base/share/classes/sun/misc/CharacterEncoder.java: 107 The

Re: RFR [9] 8080422: some docs cleanup for core libs

Hello Roger, Fixed; please see http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/index.html Regards, Alexander On 18.05.2015 17:43, Roger Riggs wrote: Hi Alexander, Thanks for these needed cleanups; a few corrections below. 1)

RFR [9] 8080422: some docs cleanup for core libs

Please see the updated webrev http://cr.openjdk.java.net/~avstepan/8080422/webrev.01/ - some misprints were fixed as well (not 100% sure if comparision should be replaced with comparison, but the latter looks more suitable). Thanks, Alexander On 15.05.2015 20:16, alexander stepanov wrote:

Re: RFR [9] 8080422: some docs cleanup for core libs

The revised changes seem OK in addition to the previous webrev Best Lance On May 18, 2015, at 11:36 AM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello Roger, Fixed; please see http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/index.html Regards, Alexander On

Re: RFR [9] 8080422: some docs cleanup for core libs

Hi Alexander, seems ok as well… On May 18, 2015, at 12:02 PM, alexander stepanov alexander.v.stepa...@oracle.com wrote: Hello, Lance, Roger, Thanks! P.S. sorry - one minor change after the review - a list was added in ExtensionDependency.java:

Re: RFR [9] 8080422: some docs cleanup for core libs

Hello, Lance, Roger, Thanks! P.S. sorry - one minor change after the review - a list was added in ExtensionDependency.java: http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/src/java.base/share/classes/sun/misc/ExtensionDependency.java.udiff.html (please update the page). Regards,

Re: RFR [9] 8080422: some docs cleanup for core libs

Hi Alexander, Thanks, Looks good to go to me. Roger On 5/18/2015 11:36 AM, alexander stepanov wrote: Hello Roger, Fixed; please see http://cr.openjdk.java.net/~avstepan/8080422/webrev.02/index.html Regards, Alexander On 18.05.2015 17:43, Roger Riggs wrote: Hi Alexander, Thanks for

RFR [9] 8080422: some docs cleanup for core libs

Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8080422/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8080422 Just some HTML markup fix. The affected packages should (probably) not be visible in the new modular system, but nevertheless...