Re: RFR [9] Remove sun.misc.Unsafe dependency from sun.nio.cs.StringUTF16

2015-12-10 Thread Alan Bateman
On 09/12/2015 11:44, Chris Hegarty wrote: Looks like the Compact Strings work inadvertently introduced a dependency on sun.misc.Unsafe. ( just temporary confusion with having two Unsafes until the jdk.unsupported module is defined ) Looks okay to me too, probably best to use the opportunity to a

Re: RFR [9] Remove sun.misc.Unsafe dependency from sun.nio.cs.StringUTF16

2015-12-09 Thread Xueming Shen
+1 On 12/9/15 3:44 AM, Chris Hegarty wrote: Looks like the Compact Strings work inadvertently introduced a dependency on sun.misc.Unsafe. ( just temporary confusion with having two Unsafes until the jdk.unsupported module is defined ) diff --git a/src/java.base/share/classes/sun/nio/cs/StringUT

Re: RFR [9] Remove sun.misc.Unsafe dependency from sun.nio.cs.StringUTF16

2015-12-09 Thread Paul Sandoz
+1 Paul. > On 9 Dec 2015, at 12:44, Chris Hegarty wrote: > > Looks like the Compact Strings work inadvertently introduced a > dependency on sun.misc.Unsafe. ( just temporary confusion with > having two Unsafes until the jdk.unsupported module is defined ) > > diff --git a/src/java.base/share/c

RFR [9] Remove sun.misc.Unsafe dependency from sun.nio.cs.StringUTF16

2015-12-09 Thread Chris Hegarty
Looks like the Compact Strings work inadvertently introduced a dependency on sun.misc.Unsafe. ( just temporary confusion with having two Unsafes until the jdk.unsupported module is defined ) diff --git a/src/java.base/share/classes/sun/nio/cs/StringUTF16.java b/src/java.base/share/classes/sun/ni