Re: RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread Joe Wang
+1 -Joe On 6/15/2020 7:09 AM, Roger Riggs wrote: Please review a test change of the test library HexPrinter. It should be comparing against the System.lineSeparator. diff --git a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java

Re: RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread igor . ignatyev
Hi Roger, LGTM, Thanks, — Igor > On Jun 15, 2020, at 7:10 AM, Roger Riggs wrote: > > Roger

RFR 15 8247521: (test) jdk/test/lib/hexdump/HexPrinterTest.java fails on windows

2020-06-15 Thread Roger Riggs
Please review a test change of the test library HexPrinter. It should be comparing against the System.lineSeparator. diff --git a/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java b/test/lib-test/jdk/test/lib/hexdump/HexPrinterTest.java ---