RE: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-08-04 Thread Vipin Mv1
ndia/IBM Date: 07/13/2020 07:13PM Cc: core-libs-dev@openjdk.java.net Subject: Re: [EXTERNAL] Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings Hi Lance Thanks for the detailed review. I will go ahead and look into the required documentation changes. Th

RE: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-07-13 Thread Vipin Mv1
-dev@openjdk.java.net Subject: [EXTERNAL] Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings Hi Vipin, Apologies for the delay. After looking at the bug, which is over 14 years old, the SCCS history of Attributes.java, I am reluctant to suggest we move forward with

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-07-09 Thread Lance Andersen
> > -Vipin Mv1/India/IBM wrote: ----- > To: core-libs-dev@openjdk.java.net > From: Vipin Mv1/India/IBM > Date: 05/11/2020 05:00PM > Subject: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings > > Hi, > > Please review t

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-06-30 Thread Vipin Mv1
n MV -Vipin Mv1/India/IBM wrote: - To: core-libs-dev@openjdk.java.net From: Vipin Mv1/India/IBM Date: 06/15/2020 11:52AM Subject: Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings Hi, I have addressed the review comm

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-06-14 Thread Vipin Mv1
0126 java.util.jar.Attributes#containsKey fails with Strings Hi, Please review the fix for the following issue. https://bugs.openjdk.java.net/browse/JDK-6470126 diff -r 53568400fec3 src/java.base/share/classes/java/util/jar/Attributes.java --- a/src/java.base/share/classes/java/util/jar/Attributes.java

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-05-15 Thread Vipin Mv1
Hi, Thanks for the review comments. I will work on the same and get back with the same soon. Thanks & Regards Vipin MV

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-05-11 Thread Lance Andersen
Hi Vipin, When you submit your revised patch addressing the input previously provided, please include a test case which exercises the various methods. Best Lance > On May 11, 2020, at 7:54 AM, Alan Bateman wrote: > > On 11/05/2020 12:44, Claes Redestad wrote: >> Hi Vipin, >> >> making cont

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-05-11 Thread Alan Bateman
On 11/05/2020 12:44, Claes Redestad wrote: Hi Vipin, making containsKey("key") return true without also ensuring the other Map operations like get, put, .. work consistently and transparently with String keys seem like a partial fix that will subtly break operations like getOrDefault. Yeah, I th

Re: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-05-11 Thread Claes Redestad
Hi Vipin, making containsKey("key") return true without also ensuring the other Map operations like get, put, .. work consistently and transparently with String keys seem like a partial fix that will subtly break operations like getOrDefault. And why not "if (name instanceof String)"? Thanks!

RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

2020-05-11 Thread Vipin Mv1
Hi, Please review the fix for the following issue. https://bugs.openjdk.java.net/browse/JDK-6470126 diff -r 53568400fec3 src/java.base/share/classes/java/util/jar/Attributes.java --- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Mar 26 15:26:51 2020 + +++ b/src/java.base/