Re: RFR 6996807 : FieldReflectorKey hash code computation can be improved

2019-01-02 Thread Roger Riggs
Hi Ivan, Happy New Year! This looks fine. The indentation of line 2311 makes it harder to see all the conditions for the true case. No new webrev needed. Thanks, Roger On 12/31/2018 11:12 PM, Ivan Gerasimov wrote: Gentle ping. I updated the copyright year, as it seems unlikely this fix

Re: RFR 6996807 : FieldReflectorKey hash code computation can be improved

2018-12-31 Thread Ivan Gerasimov
Gentle ping. I updated the copyright year, as it seems unlikely this fix is going to be reviewed in 2018 :) Happy New Year to everyone! Ivan On 12/18/18 2:42 AM, Ivan Gerasimov wrote: Hello! FieldReflectorKey class contains a combined-string representation of the fields (their names and

RFR 6996807 : FieldReflectorKey hash code computation can be improved

2018-12-18 Thread Ivan Gerasimov
Hello! FieldReflectorKey class contains a combined-string representation of the fields (their names and signatures). This string is used for calculating the hash code and comparing two FieldReflectorKey objects for equality, which is expensive. It is proposed to store the names and signatur