Re: RFR 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread Chris Hegarty
Thanks Martin. -Chris On 14 Apr 2013, at 15:55, Martin Buchholz wrote: > Looks good. > > I've made the same mistake testing CompletableFuture. > > > On Sun, Apr 14, 2013 at 2:32 AM, Chris Hegarty > wrote: >> Silly mistake in the test. Incorrectly assumes that one of the given >> Complet

Re: RFR 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread Chris Hegarty
Thanks Alan. -Chris On 14 Apr 2013, at 16:06, Alan Bateman wrote: > On 14/04/2013 10:32, Chris Hegarty wrote: >> Silly mistake in the test. Incorrectly assumes that one of the given >> CompletableFutures must be completed before applyToEitherXXX / >> acceptEitherXXX / runAfterEitherXXX / anyO

Re: RFR 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread Alan Bateman
On 14/04/2013 10:32, Chris Hegarty wrote: Silly mistake in the test. Incorrectly assumes that one of the given CompletableFutures must be completed before applyToEitherXXX / acceptEitherXXX / runAfterEitherXXX / anyOf returns. The correct assertion is that one of the given CompletableFutures mu

Re: RFR 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread Martin Buchholz
Looks good. I've made the same mistake testing CompletableFuture. On Sun, Apr 14, 2013 at 2:32 AM, Chris Hegarty wrote: > Silly mistake in the test. Incorrectly assumes that one of the given > CompletableFutures must be completed before applyToEitherXXX / > acceptEitherXXX / runAfterEitherXXX /

RFR 8011799: CompletableFuture/Basic.java fails intermittently

2013-04-14 Thread Chris Hegarty
Silly mistake in the test. Incorrectly assumes that one of the given CompletableFutures must be completed before applyToEitherXXX / acceptEitherXXX / runAfterEitherXXX / anyOf returns. The correct assertion is that one of the given CompletableFutures must be completed before the return Completa