Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Hi, Aleksej, thanks for the update. The latest version looks good. Chris, thanks for sponsoring this change. s'marks On 8/16/13 7:51 AM, Aleksej Efimov wrote: Chris, Thank you for review and for sponsorship. I have prepared hg changeset patches for root and jdk repositories: root repo patch:

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Chris, Thank you for review and for sponsorship. I have prepared hg changeset patches for root and jdk repositories: root repo patch: http://cr.openjdk.java.net/~aefimov/8021820/jdk8_hg.export jdk repo patch: http://cr.openjdk.java.net/~aefimov/8021820/jdk_jdk8_hg.export I think if there is no

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

I see no objections to this, and I think it has been through enough review. I'll sponsor this change for Aleksej. -Chris. On 13/08/2013 10:20, Aleksej Efimov wrote: Stuart, Thanks for your comments. New webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.03/

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Stuart, Thanks for your comments. New webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.03/ Comments below. Thanks, Aleksej On 08/08/2013 06:10 AM, Stuart Marks wrote: Hi Aleksej, Thanks for the update. The situation is a bi

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

On 8/8/13 1:54 AM, Chris Hegarty wrote: On 08/08/2013 03:11 AM, Jonathan Gibbons wrote: On 08/07/2013 07:10 PM, Stuart Marks wrote: I'd suggest putting a comment at the top of the test class saying that this test *must* be run in othervm mode, to ensure that files are closed properly. That way,

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

On 08/08/2013 01:54 AM, Chris Hegarty wrote: On 08/08/2013 03:11 AM, Jonathan Gibbons wrote: On 08/07/2013 07:10 PM, Stuart Marks wrote: I'd suggest putting a comment at the top of the test class saying that this test *must* be run in othervm mode, to ensure that files are closed properly. That

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

On 08/08/2013 03:11 AM, Jonathan Gibbons wrote: On 08/07/2013 07:10 PM, Stuart Marks wrote: I'd suggest putting a comment at the top of the test class saying that this test *must* be run in othervm mode, to ensure that files are closed properly. That way, you can take out the cleanupFiles() meth

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Hi Aleksej, Thanks for the update. The situation is a bit twisted. I picked up a couple clues from David Holmes and Jon Gibbons. The NoClassDefFoundError occurs when the JVM has hit its resource limit for the number of open files, *and* it is being run in a development environment with indivi

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Stuart, thank you for you comments, responses are below. New webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.02/ -Aleksej On 08/06/2013 05:14 AM, Stuart Marks wrote: Hi Aleksej, Thanks for the update. I took a look at the

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Hi Aleksej, Thanks for the update. I took a look at the revised test, and there are still some issues. (I didn't look at the build changes.) 1) System-specific resource limits. I think the biggest issue is resource limits on the number of open files per process that might vary from system to

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Alan, Tim, I have addressed your comments and as a result - new webrev: http://cr.openjdk.java.net/~aefimov/8021820/webrev.01 The list of changes: 1. The connection to Oracle site is removed (it's not internal, but anyway it's better not to rely on availability of external resource in test). I

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

On 31/07/2013 14:45, Alan Bateman wrote: On 31/07/2013 05:18, Aleksej Efimov wrote: Hi, Can I have a review for the following problem: The MACOSX JDK (more precisely - the java.net classes) uses the select() system call to wait for different events on sockets fds. And the default behaviour for s

Re: RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

On 31/07/2013 05:18, Aleksej Efimov wrote: Hi, Can I have a review for the following problem: The MACOSX JDK (more precisely - the java.net classes) uses the select() system call to wait for different events on sockets fds. And the default behaviour for select() on Darwin is to fail when fdset

RFR 8021820: Number of opened files used in select() is limited to 1024 [macosx]

Hi, Can I have a review for the following problem: The MACOSX JDK (more precisely - the java.net classes) uses the select() system call to wait for different events on sockets fds. And the default behaviour for select() on Darwin is to fail when fdset contains the fd with id greater than FDSET_