On Sep 3, 2013, at 11:13 AM, Alan Bateman wrote:
> On 02/09/2013 15:12, Paul Sandoz wrote:
>> FYI: this has been soaking in the lambda repo for over a weak now. AFAICT
>> there have been no issues.
>>
>> Paul.
>>
> If you can pull into a clone of jdk8/tl, run the tests to make sure that all
>
On 02/09/2013 15:12, Paul Sandoz wrote:
FYI: this has been soaking in the lambda repo for over a weak now. AFAICT there
have been no issues.
Paul.
If you can pull into a clone of jdk8/tl, run the tests to make sure that
all is okay then I think we should just get it in.
-Alan.
FYI: this has been soaking in the lambda repo for over a weak now. AFAICT there
have been no issues.
Paul.
On Aug 24, 2013, at 6:31 PM, Mike Duigou wrote:
> I will need to spend more time reviewing the HashMap/LinkedHashMap
> implementations but here are some initial comments.
>
> Mike
On 08/27/2013 03:51 PM, Martin Buchholz wrote:
On Tue, Aug 27, 2013 at 3:00 AM, Paul Sandoz wrote:
[...]
Note that j.u. classes are quite inconsistent in this respect to using
diamonds and @Overrides. My preference is to do a sweeping change to all
such code.
For jsr166, we continue to mai
On 08/27/2013 12:00 PM, Paul Sandoz wrote:
On Aug 26, 2013, at 11:13 PM, Remi Forax wrote:
On 08/26/2013 10:10 PM, Paul Sandoz wrote:
On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previ
On Aug 26, 2013, at 11:13 PM, Remi Forax wrote:
> On 08/26/2013 10:10 PM, Paul Sandoz wrote:
>> On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
>>
>>> On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as
On 08/26/2013 10:10 PM, Paul Sandoz wrote:
On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a
webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMa
On Aug 25, 2013, at 8:04 PM, Remi Forax wrote:
> On 08/21/2013 02:25 PM, Paul Sandoz wrote:
>> Hi,
>>
>> Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a
>> webrev:
>>
>>
>> http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/
>
On 08/21/2013 02:25 PM, Paul Sandoz wrote:
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a
webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/
I also added some tests related to characteristics associated with fix
On Aug 24, 2013, at 6:31 PM, Mike Duigou wrote:
> I will need to spend more time reviewing the HashMap/LinkedHashMap
> implementations but here are some initial comments.
>
OK, thanks.
> Mike
>
> HashMap::
>
> - The "Sorry if you don't like..." comment can be omitted.
>
Or we could twea
On Aug 24, 2013, at 1:35 AM, Brent Christian wrote:
> On 8/22/13 5:01 AM, Paul Sandoz wrote:
>> On Aug 21, 2013, at 6:47 PM, Paul Sandoz wrote:
>>> I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
>>>
>>>
>>> http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-Has
On Aug 22, 2013, at 5:33 PM, Martin Buchholz wrote:
> I support the treeification of all the HashMaps.
>
> On Wed, Aug 21, 2013 at 5:25 AM, Paul Sandoz wrote:
>
> I recommend when this code goes in we look closely at code coverage results
> to see if we are missing areas testing tree functio
I will need to spend more time reviewing the HashMap/LinkedHashMap
implementations but here are some initial comments.
Mike
HashMap::
- The "Sorry if you don't like..." comment can be omitted.
SpliteratorCharacteristics::
- style comment : I always define my assertXXX in the (value, expected
On 8/22/13 5:01 AM, Paul Sandoz wrote:
On Aug 21, 2013, at 6:47 PM, Paul Sandoz wrote:
I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.ht
On 22/08/2013 13:01, Paul Sandoz wrote:
On Aug 21, 2013, at 6:47 PM, Paul Sandoz wrote:
I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.h
On Aug 21, 2013, at 6:47 PM, Paul Sandoz wrote:
> I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
>
>
> http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.html
>
Another tweak to ensure untr
I updated the webrev and replaced TreeBinSplitBackToEntries.java with:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.html
Paul.
On Aug 21, 2013, at 4:00 PM, Paul Sandoz wrote:
> I updated the webrev to adju
I updated the webrev to adjust some tests that a JPRT run reporting as failing:
FAILED: java/util/Map/CheckRandomHashSeed.java
FAILED: java/util/Map/TreeBinSplitBackToEntries.java
The test TreeBinSplitBackToEntries needs to be revamped as the conditions under
which bins are converted to trees an
Hi,
Here are Doug's Linked/HashMap changes, discussed in a previous thread, as a
webrev:
http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/
I also added some tests related to characteristics associated with fixing
another bug.
Looking at the diffs will b
19 matches
Mail list logo
