Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Alexander Zuev
Hi Kumar, thanks for suggestion - the corrected (and simplified) webrev can be found at: http://cr.openjdk.java.net/~kizune/8025076/webrev.05 With best regards, /Alex On 9/20/13 3:20, Kumar Srinivasan wrote: Hi Alex, The class can be compiled into the current directory (scratch), this

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Naoto Sato
Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully remove them? Naoto On Sep 20, 2013, at 3:43 AM, Alexander Zuev alexander.z...@oracle.com wrote: Hi Kumar, thanks for suggestion - the corrected (and simplified) webrev can be found at:

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Alexander Zuev
Naoto, i just tested - jtreg has no issues with deleting files even in non-unicode locales. /Alex On 9/20/13 18:45, Naoto Sato wrote: Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully remove them? Naoto On Sep 20, 2013, at 3:43 AM, Alexander

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-20 Thread Naoto Sato
OK, good. Naoto On 9/20/13 8:40 AM, Alexander Zuev wrote: Naoto, i just tested - jtreg has no issues with deleting files even in non-unicode locales. /Alex On 9/20/13 18:45, Naoto Sato wrote: Is it ok to let jtreg clean up the files that contain non ascii filenames? Does it gracefully

RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-19 Thread Alexander Zuev
Hi, please review my fix for 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales The idea of the fix is to replace test case with the complex file name in it by the test that generates and compiles such file at the run time. The webrev can be found at:

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-19 Thread Naoto Sato
Hi Alex, Should the test case also check the encoding of the platform? Does it work under the environment where the encoding is, say US-ASCII? Naoto On 9/19/13 9:43 AM, Alexander Zuev wrote: Hi, please review my fix for 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-19 Thread Alexander Zuev
Hi Naoto, I've checked that it works in C locale - since I'm setting LC_CTYPE to UTF-8 before calling both javac and java everything works as expected. With best regards, /Alex 20.09.2013, в 1:34, Naoto Sato naoto.s...@oracle.com написал(а): Hi Alex, Should the test case also check the

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-19 Thread Naoto Sato
Thanks for checking. Looks good to me. Naoto On 9/19/13 3:12 PM, Alexander Zuev wrote: Hi Naoto, I've checked that it works in C locale - since I'm setting LC_CTYPE to UTF-8 before calling both javac and java everything works as expected. With best regards, /Alex 20.09.2013, в 1:34,

Re: RFR 8025076: Fix for JDK-8017248 breaks jprt submission for non-unicode locales

2013-09-19 Thread Kumar Srinivasan
Hi Alex, The class can be compiled into the current directory (scratch), this will eliminate: a. the deletion of the files and allow jtreg to clean out the scratch directory b. uses of TEST_CLASSES_DIR.getAbsolutePath(). Thanks Kumar Hi, please review my fix for 8025076: Fix for