Re: RFR 8068587: ScriptEngineFactory.getParameter() should specify NPE for a null key

2015-02-10 Thread Marcus Lagergren
Looks OK to me. +1 /M > On 10 Feb 2015, at 08:21, A. Sundararajan > wrote: > > Please review http://cr.openjdk.java.net/~sundar/8068587/ for > https://bugs.openjdk.java.net/browse/JDK-8068587 > > Thanks, > -Sundar

Re: RFR 8068587: ScriptEngineFactory.getParameter() should specify NPE for a null key

2015-02-10 Thread Alan Bateman
On 10/02/2015 07:21, A. Sundararajan wrote: Please review http://cr.openjdk.java.net/~sundar/8068587/ for https://bugs.openjdk.java.net/browse/JDK-8068587 This looks okay to me although it makes me wonder if JSR-223 will need to be updated. -Alan.

RFR 8068587: ScriptEngineFactory.getParameter() should specify NPE for a null key

2015-02-09 Thread A. Sundararajan
Please review http://cr.openjdk.java.net/~sundar/8068587/ for https://bugs.openjdk.java.net/browse/JDK-8068587 Thanks, -Sundar