Re: RFR 8085978 LinkedTransferQueueT.spliterator can report LTQ.Node object, not T

2015-06-16 Thread Paul Sandoz
On Jun 15, 2015, at 6:18 PM, Martin Buchholz marti...@google.com wrote: This is a fine fix for a jdk8 backport. Thanks, i deliberately kept it simple to make the backport easier. In pursuit of even more perfection for jdk9, we might do some more fiddling later. Ok. It bothers me

RFR 8085978 LinkedTransferQueueT.spliterator can report LTQ.Node object, not T

2015-06-15 Thread Paul Sandoz
Hi, Please review: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8085978-linked-transfer-queue-traverse/webrev/ The LinkedTransferQueue's spliterator can erroneously report internal nodes when traversing. The fix is cherry picked from the 166 repo (other mostly refactoring-based changes

Re: RFR 8085978 LinkedTransferQueueT.spliterator can report LTQ.Node object, not T

2015-06-15 Thread Martin Buchholz
This is a fine fix for a jdk8 backport. In pursuit of even more perfection for jdk9, we might do some more fiddling later. It bothers me that not all the traversal loops in LTQ work the same. Other traversal loops simply skip over matched request nodes, but the spliterator traversals do not