Re: RFR 8154192: Deprivilege java.scripting module

2016-05-18 Thread Mandy Chung
> On May 18, 2016, at 12:55 AM, Sundararajan Athijegannathan > wrote: > > Please review the updated webrevs. > > * Fixed Modules.gmk for order of modules: > > http://cr.openjdk.java.net/~sundar/8154192/top/webrev.01/ > > * From quick reading of j.u.ServiceLoader: AccessControlContext is > ca

Re: RFR 8154192: Deprivilege java.scripting module

2016-05-18 Thread Sundararajan Athijegannathan
Thanks. I'll make that change and push it. -Sundar On 5/18/2016 2:17 PM, Alan Bateman wrote: > On 18/05/2016 08:55, Sundararajan Athijegannathan wrote: >> Please review the updated webrevs. >> >> * Fixed Modules.gmk for order of modules: >> >> http://cr.openjdk.java.net/~sundar/8154192/top/webrev

Re: RFR 8154192: Deprivilege java.scripting module

2016-05-18 Thread Alan Bateman
On 18/05/2016 08:55, Sundararajan Athijegannathan wrote: Please review the updated webrevs. * Fixed Modules.gmk for order of modules: http://cr.openjdk.java.net/~sundar/8154192/top/webrev.01/ * From quick reading of j.u.ServiceLoader: AccessControlContext is captured in ServiceLoader construct

Re: RFR 8154192: Deprivilege java.scripting module

2016-05-18 Thread Sundararajan Athijegannathan
Please review the updated webrevs. * Fixed Modules.gmk for order of modules: http://cr.openjdk.java.net/~sundar/8154192/top/webrev.01/ * From quick reading of j.u.ServiceLoader: AccessControlContext is captured in ServiceLoader constructor & used for iteration (RestrictedIterator). So, ScriptEng

Re: RFR 8154192: Deprivilege java.scripting module

2016-05-17 Thread Alan Bateman
On 17/05/2016 13:04, Sundararajan Athijegannathan wrote: Please review fix for https://bugs.openjdk.java.net/browse/JDK-8154192 java.scripting module is assigned to platform class loader (instead of boot loader). And java.scripting module is given AllPermission [previously it had AllPermission i

Re: RFR 8154192: Deprivilege java.scripting module

2016-05-17 Thread Jim Laskey (Oracle)
+1 > On May 17, 2016, at 9:04 AM, Sundararajan Athijegannathan > wrote: > > Please review fix for https://bugs.openjdk.java.net/browse/JDK-8154192 > > java.scripting module is assigned to platform class loader (instead of > boot loader). And java.scripting module is given AllPermission > [prev

RFR 8154192: Deprivilege java.scripting module

2016-05-17 Thread Sundararajan Athijegannathan
Please review fix for https://bugs.openjdk.java.net/browse/JDK-8154192 java.scripting module is assigned to platform class loader (instead of boot loader). And java.scripting module is given AllPermission [previously it had AllPermission implicitly because of being boot loader code] jdk repo: ht