Looks good.
Best regards,
Vladimir Ivanov
On 5/3/16 1:37 AM, Paul Sandoz wrote:
Hi,
Please review:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-jdk/webrev/
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-hotspot/webrev
- Mail original -
> De: "Paul Sandoz"
> Cc: "hotspot-dev developers" , "Core-Libs-Dev"
>
> Envoyé: Mardi 3 Mai 2016 22:03:12
> Objet: Re: RFR 8155794 Move Objects.checkIndex BiFunction accepting methods
> to an internal packa
> On 3 May 2016, at 07:05, Remi Forax wrote:
>
> Looks good to me.
> minor nitpick, neither checkFromToIndex() nor checkFromIndexSize() are
> instrinsic (now !) but i think they also should be annotated with
> @ForceInline in j.u.Objects to avoid the code to be asymmetric or weird if
> one of
original -
> De: "Paul Sandoz"
> À: "Core-Libs-Dev" , "hotspot-dev developers"
>
> Envoyé: Mardi 3 Mai 2016 00:37:36
> Objet: RFR 8155794 Move Objects.checkIndex BiFunction accepting methods to
> an internal package
>
> Hi,
>
>
On 05/03/2016 01:37 AM, Paul Sandoz wrote:
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-jdk/webrev/
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-hotspot/webrev/
Both JDK and HS changes look good to me.
It's somewh
On 2 May 2016, at 23:37, Paul Sandoz wrote:
> Hi,
>
> Please review:
>
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-jdk/webrev/
>
> http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-hotspot/webrev/
The changes look fine
Hi,
Please review:
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-jdk/webrev/
http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8155794-checkIndex-bifunc-internal-hotspot/webrev/
This patch is based on that for 8155258 (VarHandle impl improvements) [1] sent
pre
