Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-16 Thread Andrew Haley
On 16/08/16 03:05, David Holmes wrote: > hs-comp is the team forest for the compiler team. If you are working > primarily on hotspot compiler issues and want to integrate with latest > work the compiler team is doing, and/or you have shared compiler > changes, then you would push to hs-comp. >

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-15 Thread David Holmes
Hi Andrew, On 16/08/2016 3:59 AM, Andrew Haley wrote: On 15/08/16 18:40, Aleksey Shipilev wrote: On 08/15/2016 08:15 PM, Andrew Haley wrote: has anyone looked at this yet? I've just got back from my travels. I think it was reviewed and committed, as "HG Updater" comments say: https://bugs.

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-15 Thread Aleksey Shipilev
On 08/15/2016 08:59 PM, Andrew Haley wrote: > On 15/08/16 18:40, Aleksey Shipilev wrote: >> On 08/15/2016 08:15 PM, Andrew Haley wrote: >>> has anyone looked at this yet? I've just got back from my travels. >> >> I think it was reviewed and committed, as "HG Updater" comments say: >> https://bugs

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-15 Thread Andrew Haley
On 15/08/16 18:40, Aleksey Shipilev wrote: > On 08/15/2016 08:15 PM, Andrew Haley wrote: >> has anyone looked at this yet? I've just got back from my travels. > > I think it was reviewed and committed, as "HG Updater" comments say: > https://bugs.openjdk.java.net/browse/JDK-8162458 Hmm, okay.

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-15 Thread Aleksey Shipilev
On 08/15/2016 08:15 PM, Andrew Haley wrote: > has anyone looked at this yet? I've just got back from my travels. I think it was reviewed and committed, as "HG Updater" comments say: https://bugs.openjdk.java.net/browse/JDK-8162458 Thanks, -Aleksey

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-08-15 Thread Andrew Haley
Hi, On 27/07/16 12:47, Paul Sandoz wrote: > I made an embarrassing mistake in the fix for > > https://bugs.openjdk.java.net/browse/JDK-8151163 > All Buffer implementations should leverage Unsafe unaligned accessors > > The offset calculation for Unsafe access was incorrect, it’s easy to > g

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-07-28 Thread Daniel D. Daugherty
Paul, I have marked this bug (JDK-8162458) as an 'integration_blocker' in order to keep JDK-8151163 from leaving JDK9-hs in its current state. Dan On 7/28/16 4:33 AM, Paul Sandoz wrote: Hooking in nio dev. I think this issue is important to review/push soon (i.e. this week) so as it does no

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-07-28 Thread Paul Sandoz
> On 28 Jul 2016, at 12:40, Alan Bateman wrote: > > On 27/07/2016 12:47, Paul Sandoz wrote: > >> Hi, >> >> I made an embarrassing mistake in the fix for >> >> https://bugs.openjdk.java.net/browse/JDK-8151163 >> All Buffer implementations should leverage Unsafe unaligned accessors >> >> T

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-07-28 Thread Alan Bateman
On 27/07/2016 12:47, Paul Sandoz wrote: Hi, I made an embarrassing mistake in the fix for https://bugs.openjdk.java.net/browse/JDK-8151163 All Buffer implementations should leverage Unsafe unaligned accessors The offset calculation for Unsafe access was incorrect, it’s easy to get conf

Re: RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-07-28 Thread Paul Sandoz
Hooking in nio dev. I think this issue is important to review/push soon (i.e. this week) so as it does not leak out beyond the hs repo. — Incidentally this patch also fixes what might have been a long standing bug in the compact method of buffer views. Here is ByteBufferAsIntBufferB’s compact

RFR 8162458 Buffer view implementations use incorrect offset for Unsafe access

2016-07-27 Thread Paul Sandoz
Hi, I made an embarrassing mistake in the fix for https://bugs.openjdk.java.net/browse/JDK-8151163 All Buffer implementations should leverage Unsafe unaligned accessors The offset calculation for Unsafe access was incorrect, it’s easy to get confused because for heap buffers the offset is r