Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-09-07 Thread Paul Sandoz
> On 7 Sep 2016, at 00:49, Stefan Zobel wrote: > > 2016-09-07 1:22 GMT+02:00 Paul Sandoz : >> >>> On 3 Sep 2016, at 15:06, Stefan Zobel wrote: >>> >>> Hi Paul, >>> >>> there's a small copy & paste error in the code

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-09-07 Thread Stefan Zobel
2016-09-07 1:22 GMT+02:00 Paul Sandoz : > >> On 3 Sep 2016, at 15:06, Stefan Zobel wrote: >> >> Hi Paul, >> >> there's a small copy & paste error in the code samples in >> Double/Int/LongStream#iterate() >> >> Example DoubleStream#iterate: >> >>

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-09-06 Thread Paul Sandoz
> On 3 Sep 2016, at 15:06, Stefan Zobel wrote: > > Hi Paul, > > there's a small copy & paste error in the code samples in > Double/Int/LongStream#iterate() > > Example DoubleStream#iterate: > > * {@code > * for (T index=seed; hasNext.test(index); index =

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-09-03 Thread Stefan Zobel
Hi Paul, there's a small copy & paste error in the code samples in Double/Int/LongStream#iterate() Example DoubleStream#iterate: * {@code * for (T index=seed; hasNext.test(index); index = next.apply(index)) { * ... * } * } That should be * for

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-08-29 Thread Tagir Valeev
Hello! Changes look ok to me, thanks. With best regards, Tagir Valeev. On Mon, Aug 29, 2016 at 8:04 PM, Paul Sandoz wrote: > Thanks, updated in place, > Paul. > > > On 26 Aug 2016, at 17:20, Stuart Marks wrote: > > > > Hi Paul, > > > > Overall

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-08-29 Thread Paul Sandoz
Thanks, updated in place, Paul. > On 26 Aug 2016, at 17:20, Stuart Marks wrote: > > Hi Paul, > > Overall looks good. > > A couple minor wording comments. For the 3-arg collectors, the combiner arg > is defined as > > * @param combiner an

Re: RFR 8164691 Stream specification clarifications for iterate and collect

2016-08-26 Thread Stuart Marks
Hi Paul, Overall looks good. A couple minor wording comments. For the 3-arg collectors, the combiner arg is defined as * @param combiner an associative, *href="package-summary.html#NonInterference">non-interfering, *stateless *

RFR 8164691 Stream specification clarifications for iterate and collect

2016-08-26 Thread Paul Sandoz
Hi, Please review some minor tweaks to the stream specification: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8164691-stream-iterate-collect-spec-updates/webrev/index.html The first