Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-09 Thread harold seigel
Thanks Lois, for the review. Harold On 9/8/2016 1:12 PM, Lois Foltan wrote: On 9/8/2016 9:23 AM, harold seigel wrote: Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multip

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-09 Thread harold seigel
Hi Gerard, Thanks for the review! Please see comments inline. Harold On 9/8/2016 12:24 PM, Gerard Ziemski wrote: hi Harold, The changes look fine. I have a couple of questions though: #1 Would the "test/runtime/modules/ModuleOptionsTest.java” be more robust if we included a case with a no

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Alan Bateman
On 08/09/2016 20:38, Mandy Chung wrote: : Yes everything counts. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8165634/webrev.01/ Looks good. -Alan

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Mandy Chung
> On Sep 8, 2016, at 10:59 AM, Alan Bateman wrote: > > > > On 08/09/2016 14:23, harold seigel wrote: >> Hi, >> >> Please review this fix for JDK-8165634. The fix changes the --add-modules >> option from being a 'last one wins' option to a cumulative one. With this >> change, if multiple -

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Alan Bateman
On 08/09/2016 14:23, harold seigel wrote: Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multiple --add-modules options are specified, the VM accumulates all the options' va

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Calvin Cheung
On 9/8/16, 10:12 AM, Lois Foltan wrote: On 9/8/2016 9:23 AM, harold seigel wrote: Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multiple --add-modules options are specifi

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Lois Foltan
On 9/8/2016 9:23 AM, harold seigel wrote: Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multiple --add-modules options are specified, the VM accumulates all the options' val

Re: RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread Gerard Ziemski
hi Harold, The changes look fine. I have a couple of questions though: #1 Would the "test/runtime/modules/ModuleOptionsTest.java” be more robust if we included a case with a non-error return value that takes more than one module? Ex: “java --add-modules=java.base --add-modules=jdk.internal.ref

RFR 8165634: Support multiple --add-module options on the command line

2016-09-08 Thread harold seigel
Hi, Please review this fix for JDK-8165634. The fix changes the --add-modules option from being a 'last one wins' option to a cumulative one. With this change, if multiple --add-modules options are specified, the VM accumulates all the options' values, instead of ignoring all but the last o